From: Unknown <unknown@unknown.invalid>
To: 44905@debbugs.gnu.org
Subject: bug#44905: 27.1; Packages that customize xref-show-xrefs-function can break Dired's dired-do-find-regexp-and-replace
Date: Fri, 27 Nov 2020 21:14:39 +0100 [thread overview]
Message-ID: <m1zh32imkw.fsf@yahoo.es> (raw)
In-Reply-To: m1zh32imkw.fsf.ref@yahoo.es
Scenario: A package customizes xref-show-refs-function to use a
different UI to show xref results. If that function does not return a
valid xref buffer, then Dired's dired-do-find-regexp-and-replace (bound
to Q by default) won't work anymore because it calls
xref-query-replace-in-results on the buffer returned by
xref--show-xrefs.
A workaround is that the package explicitly calls
xref--show-xref-buffer, which is done for example at
https://github.com/alexmurray/ivy-xref/commit/aa97103ea8ce6ab8891e34deff7d43aa83fe36dd,
but it doesn't feel like an ideal solution because of the duplicated
work.
Is there a way dired-do-find-regexp-and-replace could not depend on an
actual xref buffer to perform the replacement?
next parent reply other threads:[~2020-11-27 20:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1zh32imkw.fsf.ref@yahoo.es>
2020-11-27 20:14 ` Unknown [this message]
2020-11-28 19:04 ` bug#44905: 27.1; Packages that customize xref-show-xrefs-function can break Dired's dired-do-find-regexp-and-replace Dmitry Gutov
2020-11-29 12:57 ` Unknown
2020-11-30 1:00 ` Dmitry Gutov
2020-11-30 15:26 ` Eli Zaretskii
2020-12-01 1:50 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1zh32imkw.fsf@yahoo.es \
--to=unknown@unknown.invalid \
--cc=44905@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.