From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master 0023891e842: Support hints in the :repeat keyword of defvar-keymap for repeat-mode Date: Wed, 08 May 2024 18:40:01 +0200 Message-ID: References: <171463246897.31562.10434330482523385662@vcs2.savannah.gnu.org> <20240502064749.54E89C1F9D4@vcs2.savannah.gnu.org> <86cypyi1b3.fsf@mail.linkov.net> <86seyth72k.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28597"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: JD Smith , emacs-devel To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 08 18:41:01 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s4kLk-0007Nu-TA for ged-emacs-devel@m.gmane-mx.org; Wed, 08 May 2024 18:41:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4kKy-0005G4-T4; Wed, 08 May 2024 12:40:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4kKx-0005El-1P for emacs-devel@gnu.org; Wed, 08 May 2024 12:40:11 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4kKs-0004Cx-R9 for emacs-devel@gnu.org; Wed, 08 May 2024 12:40:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1715186405; bh=yZ8zMCea0m0+WKN7pNrBvc7lm2uR/NjqYZBLEqsgz4U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ouAM942XMZ27Ig7uFrQpYljoDCbj9MbMWt+LIlfZz1VlrN+0XrLB+gaxFQ6RkQKBM NV1g+Oln/VuUE4PP8hvlHy5pm0KVxHAXkKMJsBA+iKu69xlTBtRkhpc8ccwTET3D0S ix7lJ6aP9gSbqBYT+DyyTF+bBNYZwR8NRVpJxZt5sWt7GXREK4Pcj7UMPMiovI7SfI 5YGFF6lUVMgyK35CgyVi9yiVymLxHap9/afjjvx1kk5ZTDdAx1Ft0vZVIhCJy6J35O 3ZYXXfGFaEBsIT7inDSSd0w6VMjHloIFHI/oedFpPwprLu1BneTIcOB7J1ec90jBDi f0OAWB4vQjGsA== In-Reply-To: <86seyth72k.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 07 May 2024 20:20:51 +0300") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319017 Archived-At: Juri Linkov writes: >>>>> Lastly, it could be nice to make the appearance of the prompt more in >>>>> line with the read-multiple-choice prompt, which is conceptually very >>>>> similar. Crucially, if the key is a character that occurs in the label, >>>>> it's better, IMO, to highlight the first occurrence of that character in >>>>> the label (as r-m-c does) than to prefix the label with that character. >>>>> We can reuse rmc--add-key-description for that purpose, as follows: >>>> >>>> Nice idea. A small problem is that when hints are not used, >>>> it inserts an extra space between the character and comma. >> >> Well spotted. How about something like the diff below? > > This looks better, thanks. Great, pushed to master (commit 840c33070dc).