From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Date: Fri, 12 Jul 2024 12:20:01 +0200 Message-ID: References: <86ikxltzhx.fsf@mail.linkov.net> <861q49a8vt.fsf@gnu.org> <86y16h8olf.fsf@gnu.org> <878qyh79ov.fsf@gmx.net> <86zfqxqi6e.fsf@mail.linkov.net> <87v81l5aal.fsf@gmx.net> <864j9581zr.fsf@gnu.org> <87r0c957v2.fsf@gmx.net> <86y16h6llv.fsf@gnu.org> <86r0bzks7c.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25857"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: basil@contovou.net, stephen.berman@gmx.net, 71927@debbugs.gnu.org, kickingvegas@gmail.com, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 12 12:21:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sSDP7-0006OF-PR for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jul 2024 12:21:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sSDOt-0001gx-3a; Fri, 12 Jul 2024 06:21:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSDOg-0001ff-Ua for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 06:21:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sSDOf-00065A-Rt for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 06:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sSDOf-0007E7-V9 for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 06:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jul 2024 10:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71927 X-GNU-PR-Package: emacs Original-Received: via spool by 71927-submit@debbugs.gnu.org id=B71927.172077961027704 (code B ref 71927); Fri, 12 Jul 2024 10:21:01 +0000 Original-Received: (at 71927) by debbugs.gnu.org; 12 Jul 2024 10:20:10 +0000 Original-Received: from localhost ([127.0.0.1]:53251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSDNp-0007Cl-V0 for submit@debbugs.gnu.org; Fri, 12 Jul 2024 06:20:10 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:54442 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSDNk-0007CT-Ue; Fri, 12 Jul 2024 06:20:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1720779604; bh=8UxWFC3x2M+V0C2g9GcTSXtc7SsvpIbM06RX9n5ZH2I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=vf+rcCzZZ0Io7v+LqSsIuQHwuDkgEq/id27Fp+as27TkwrHdS5PPqvwRttTirxuZ6 And1c8jYAfdlh0YsQIN22krvMcl29iQ17JEQ5969uXj4zUqWwi0ltD4UyG7JSnPdwp WMDNfu9JrlQPHFFoKU6nNSTQxYKS4t4wnYMO0qm1rSdx8Ouk+OhS5C0vx4kewetrD1 +h3PQWWD3c4+aL4pdBdVkOmI+rrha0h+c+h+JnObYISSOaeFBYdRLA35oWAh9hU69X l4BG2rtHRdWpdOy1SOfjNMGyPx0Z3EP+4RArvhzUbNVRvkvwu/zFB0yW9Lb+kPetbU tVqsA5YUX6tqA== In-Reply-To: <86r0bzks7c.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Jul 2024 10:03:19 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288772 Archived-At: close 71927 30.1 quit Eli Zaretskii writes: >> From: Eshel Yaron >>=20 >> Actually, there's another problem with the way ibuffer-do-isearch is >> currently defined via define-ibuffer-op: the BODY of the definition is a >> call to multi-isearch-buffers, but the BODY is called for each marked >> buffer, not once for all of them, so this command currently calls >> multi-isearch-buffers repeatedly when there are multiple marked buffers. >> This causes multi-isearch-setup to be called while multi-buffer Isearch >> is already in progress, which unfortunately breaks regular Isearch for >> the rest of the session. >>=20 >> To see this effect, invoke ibuffer-do-isearch with two or more marked >> buffers, quit or finish the search (e.g. type C-g), and then try regular >> Isearch with C-s and repeat C-s until wrapping around. But instead of >> wrapping around as expected, Emacs displays an error: >>=20 >> Symbol=E2=80=99s function definition is void: nil >>=20 >> A simple solution is to use plain defun for these commands, as follows: > > Thanks. Since there were no objections in a week, and Juri also > agreed with this solution, please install this on the emacs-30 branch. Done, in commit d68a4ea3ec6. I'm therefore closing this bug report. Best, Eshel