From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72759: 31.0.50; Emacs hangs with open-paren-in-column-0-is-defun-start set to nil Date: Fri, 23 Aug 2024 07:54:25 +0200 Message-ID: References: <868qwou8pv.fsf@gnu.org> <861q2gu56u.fsf@gnu.org> <86msl4slwv.fsf@gnu.org> <86ed6gsfm3.fsf@gnu.org> <86a5h4sast.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35841"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72759@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 23 07:55:43 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shNGw-00099k-MH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Aug 2024 07:55:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shNGY-00072B-AV; Fri, 23 Aug 2024 01:55:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shNGW-00071T-EA for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 01:55:16 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shNGV-0000nP-QQ for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 01:55:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=pnVBqq+p6wlZjfELtpUSQDkkOZKJvFv5KvyZHU/vHTo=; b=vuMh3djPALeS0AEbnF2rvy4Oee5nyy4ybm98dxvEL9ufj9O/Rtf98/xd5OCTBmTkzM0/hBqCYkl/lTR5hons30V4DH4WoEw2VsHJaML8ReyWuDieSog6Qm6dGnusBr37NJsylD/DFns9yPcNW9LnfjR0AHKpMfYCOU4v4fiJunNZ1ggVlb3dCTC9wlFrHGaBX7XRrWXWtw8e3HV+Rk0GFHMrlJC6q5SEWD1RnrPFNKpKk0RPS9UxgwSOzbj4tgPLNufkphuxDbA25TMojqf4iicPr+RWzZm2GVPGlNrdfyFQXs8v8Mf3I1ofd7FH8YX/3mcLz9BwAUq4j7ALgqE0IA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shNHG-0004Ju-2C for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 01:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2024 05:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72759 X-GNU-PR-Package: emacs Original-Received: via spool by 72759-submit@debbugs.gnu.org id=B72759.172439252816549 (code B ref 72759); Fri, 23 Aug 2024 05:56:02 +0000 Original-Received: (at 72759) by debbugs.gnu.org; 23 Aug 2024 05:55:28 +0000 Original-Received: from localhost ([127.0.0.1]:38704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shNGg-0004Ip-P4 for submit@debbugs.gnu.org; Fri, 23 Aug 2024 01:55:28 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:36104 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shNGU-0004IU-VI for 72759@debbugs.gnu.org; Fri, 23 Aug 2024 01:55:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1724392467; bh=a21Sde43IHcQeZTqZP/4gpd3XEd85tzjImH9zX0y2iM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IPsrJK4kqJl+ZPsAh6NeN47fxjaS3IwsIrbOtX76G8myt5O0nHUhZIzH1XiNGLOzI DgyeGDNZtmlF/+ULBNSyvH9C4V2lRlXN7tmcRJ3nL0d0gyninIAm3VQjylyRUabsBD s+MOrsVYyH2UquMrnDGhilfWW1FiLtIXLguscJ3qMuuRmivFsFncF7SrnwT75G7GZg 9fsbFnXu2XWCPJ5duSbGXtpbXPVJii6o+6J5t6Zclssj4lWuVicAdRZIWDN35mOhyk B098JY+XFNhPLLf8Jg+iP2qtrdvCjVHpNlP85k70lJyNU3MnBREdcBYrmPUqobQ1uq qu7+R7H9oU+wg== In-Reply-To: <86a5h4sast.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 22 Aug 2024 20:54:26 +0300") X-Hashcash: 1:20:240823:eliz@gnu.org::iVbOwnmcZ9SUlObq:0Am/ X-Hashcash: 1:20:240823:72759@debbugs.gnu.org::5m8XBu1w17gelfCV:qwM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290573 Archived-At: Hi Eli, Eli Zaretskii writes: >> >> diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el >> >> index 949ca6b74ad..65226d8ee44 100644 >> >> --- a/lisp/emacs-lisp/checkdoc.el >> >> +++ b/lisp/emacs-lisp/checkdoc.el >> >> @@ -981,7 +981,7 @@ checkdoc-next-docstring >> >> Return nil if there are no more doc strings." >> >> (let (found) >> >> (while (and (not (setq found (checkdoc--next-docstring))) >> >> - (beginning-of-defun -1))) >> >> + (beginning-of-defun-raw -1))) >> >> found)) > I'm trying to understand what kind of behavior change could be caused > by your proposed change, which is why what beginning-of-defun-raw does > and beginning-of-defun doesn't is important, especially if some user > options can affect that. E.g., does anything change in this scenario > if defun-prompt-regexp is non-nil? This change is the correct also when defun-prompt-regexp is non-nil. Take a look at beginning-of-defun, it just calls beginning-of-defun-raw after possibly pushing a mark, and then it calls beginning-of-line. We're not interested in pushing a mark here, neither do we want to move back to beginning of the line after each call (that yields an infloop), so beginning-of-defun-raw fits the bill precisely. Best, Eshel