From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 8064b2a6798: Document undocumented completion commands Date: Sun, 05 Jan 2025 09:06:04 +0100 Message-ID: References: <173506838079.2264184.7348874799811402829@vcs3.savannah.gnu.org> <20241224192621.31046CA6ED0@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12129"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 05 09:07:10 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tULfB-000303-9u for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Jan 2025 09:07:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tULeN-0001rU-ND; Sun, 05 Jan 2025 03:06:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tULeL-0001qw-Jk for emacs-devel@gnu.org; Sun, 05 Jan 2025 03:06:17 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tULeK-0006LM-4p; Sun, 05 Jan 2025 03:06:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1736064375; bh=fnAyWjTI3/HLAdjh8K7Oh0u/8JpoSvNd+LmjAW97hH0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=LhpK8MZeNSoGkvXhhaLqH4P0gUqH0zuvS65pnPSVyVCLeAj9uETAM+jdGcdbBLNpO Fm2e2oy0KeJnQY5A4AwbGX5NmLD0OLR4ZRotF/h5MgB1PsJLPV5vk51K8esu3HaXH+ JEl9yZMF2yW9gzK1eGuysbAbNdLP4WPX3IiZRy/ZdsRLZV8FlH2KIs5bS8aBm+SIi3 Dx0ozGARbUkUHcQGFf8S0jD4f4WXBwAphKiJbzsqp/qdWUtbVBc5C/7pFdaLYon6NH rUFcmjOEsWfuwD/fboJk6dCBBQESkjUk5Ns5HOHrb/8mCkEttOBTlnmqA4pkGAcGUC Yzd0oN8Ke/Kmw== In-Reply-To: <20241224192621.31046CA6ED0@vcs3.savannah.gnu.org> (Eli Zaretskii's message of "Tue, 24 Dec 2024 14:26:20 -0500 (EST)") X-Hashcash: 1:20:250105:emacs-devel@gnu.org::3C1KwTnJEjVuQ1kb:lkm X-Hashcash: 1:20:250105:eliz@gnu.org::8jRHf5vbOKTVl0Tw:1l4/ Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327709 Archived-At: Hi, Eli Zaretskii writes: > branch: emacs-30 > commit 8064b2a67988e815c52e289fe2a235ce1008776f > Author: Eli Zaretskii > Commit: Eli Zaretskii > > Document undocumented completion commands Thanks for this. > diff --git a/src/minibuf.c b/src/minibuf.c > index f16880011f7..83b1fa024f8 100644 > --- a/src/minibuf.c > +++ b/src/minibuf.c > @@ -1293,6 +1293,11 @@ barf_if_interaction_inhibited (void) > DEFUN ("read-from-minibuffer", Fread_from_minibuffer, > Sread_from_minibuffer, 1, 7, 0, > doc: /* Read a string from the minibuffer, prompting with string PROMPT. > +While in the minibuffer, you can use \\\\[minibuffer-complete] and \\[minibuffer-complete-word] to complete your input. > +You can also use \\\\[minibuffer-complete-history] to complete using history items in the > +input history HIST, and you can use \\[minibuffer-complete-defaults] to complete using > +the default items in DEFAULT-VALUE. > + > The optional second arg INITIAL-CONTENTS is an obsolete alternative to > DEFAULT-VALUE. It normally should be nil in new code, except when > HIST is a cons. It is discussed in more detail below. This part isn't quite right: read-from-minibuffer does not provide completion with minibuffer-complete[-word] by default. How about just dropping these references? Something like: diff --git a/src/minibuf.c b/src/minibuf.c index 6ac3216a62f..becc3a9f26c 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -1297,8 +1297,7 @@ barf_if_interaction_inhibited (void) DEFUN ("read-from-minibuffer", Fread_from_minibuffer, Sread_from_minibuffer, 1, 7, 0, doc: /* Read a string from the minibuffer, prompting with string PROMPT. -While in the minibuffer, you can use \\\\[minibuffer-complete] and \\[minibuffer-complete-word] to complete your input. -You can also use \\\\[minibuffer-complete-history] to complete using history items in the +While in the minibuffer, you can use \\\\[minibuffer-complete-history] to complete using history items in the input history HIST, and you can use \\[minibuffer-complete-defaults] to complete using the default items in DEFAULT-VALUE.