From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#16038: 24.3; latest change to with-help-window makes temp-buffer-browse useless Date: Wed, 22 Jan 2014 11:32:00 +0800 Message-ID: References: <52D14E9F.5030001@gmx.at> <52D16627.4080604@gmx.at> <52D2661A.4000105@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1390361952 16157 80.91.229.3 (22 Jan 2014 03:39:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Jan 2014 03:39:12 +0000 (UTC) Cc: 16038@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 22 04:39:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W5oes-0003Jv-FE for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Jan 2014 04:39:18 +0100 Original-Received: from localhost ([::1]:33428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5oer-00085k-LB for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Jan 2014 22:39:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5oej-00085b-1J for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2014 22:39:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5oed-0002L8-7c for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2014 22:39:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5oed-0002L3-3O for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2014 22:39:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W5oec-0003Tj-JJ for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2014 22:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jan 2014 03:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16038 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16038-submit@debbugs.gnu.org id=B16038.139036189513284 (code B ref 16038); Wed, 22 Jan 2014 03:39:02 +0000 Original-Received: (at 16038) by debbugs.gnu.org; 22 Jan 2014 03:38:15 +0000 Original-Received: from localhost ([127.0.0.1]:60094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5odq-0003S9-5C for submit@debbugs.gnu.org; Tue, 21 Jan 2014 22:38:14 -0500 Original-Received: from mail-pa0-f46.google.com ([209.85.220.46]:43481) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5odm-0003Rx-15 for 16038@debbugs.gnu.org; Tue, 21 Jan 2014 22:38:10 -0500 Original-Received: by mail-pa0-f46.google.com with SMTP id rd3so9224332pab.5 for <16038@debbugs.gnu.org>; Tue, 21 Jan 2014 19:38:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=6lYcGCUo7OpSWMF5JuAyxgIHwAAGeZ5fmIthhmstr3U=; b=dzyOjFuV8fCsdQD83Al9cZvbUe/duQEw8Gq294wkNOnu5ESxdrzOTxAWRJSupIgJZE YoWosSfsIKqv9sA+d5QMf93oMMmxu2iyYI5zv3PM9ePQtxALQCmtogkJ7nhsabTtAdql QDvj0Byw0ojYKfLo2fzLbPUYYtRxQYKDaLD67owfGP1bunNpcd6yTFCLaaTl0l+fKf0V 0zePRlLSiVeR5ZKZ9U57rlF8qFFlEsxIIVSzDS2TRHO93dsdoQ1C3R5OL8HecOIeK0Kx Qk0P/Y2wY1ncvUSOKdQqh0A519eLELqe3lOXhYSBOnuhQcp/99H1+yhjzg689KxM1PR4 /GfQ== X-Received: by 10.66.149.37 with SMTP id tx5mr28407469pab.81.1390361528567; Tue, 21 Jan 2014 19:32:08 -0800 (PST) Original-Received: from Zeuss-MacBook.local ([124.64.111.76]) by mx.google.com with ESMTPSA id zc5sm17299070pbc.41.2014.01.21.19.32.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jan 2014 19:32:08 -0800 (PST) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= In-Reply-To: (Stefan Monnier's message of "Tue, 21 Jan 2014 22:02:25 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83869 Archived-At: On 2014-01-22 11:02 +0800, Stefan Monnier wrote: [snipped 7 lines] > Could you explain why it doesn't have any ill-effect? > Put it another way, could you try to characterize in which case it would > make a difference, and then try and figure out (or argue) that such > a situation never happens or at least is very unlikely. > > > Stefan On 2014-01-22 11:07 +0800, Glenn Morris wrote: [snipped 3 lines] > bzr log -c 1 > > -> timestamp: Thu 1985-04-18 00:48:29 +0000 > > > Anyway, vc-annotate is your friend: > > (add-hook 'temp-buffer-setup-hook 'help-mode-setup) > appeared in r24049, 1999-01-11. > > (add-hook 'temp-buffer-show-hook 'help-mode-finish) > appeared in r20061, 1997-10-15 (as help-mode-maybe). Thanks. ------------------------------------------------------------ revno: 20061 committer: Karl Heuer timestamp: Wed 1997-10-15 23:36:30 +0000 message: (help-mode-maybe): New function, on temp-buffer-show-hook. (describe-key, describe-mode): Don't call help-mode here. (view-lossage, describe-function, describe-variable): Likewise. ------------------------------------------------------------ revno: 24049 committer: Richard M. Stallman timestamp: Mon 1999-01-11 15:25:41 +0000 message: (help-mode-finish): Renamed from help-mode-maybe. Don't switch to Help mode here. (temp-buffer-setup-hook): Use help-mode-finish. (help-mode-setup): New function. (temp-buffer-setup-hook): Use help-mode-setup. So these hooks were added for help mode which is no longer using with-output-to-temp-buffer but with-temp-buffer-window i.e. they are not needed any more. Stefan, do you have anything in mind that might be affected without these add-hooks? Removing them would of course leave temp-buffers in fundamental mode. But other than that I haven't seen anything strange. Leo