From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eshel Yaron via "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#66394: 29.1; Make register-read-with-preview more useful
Date: Sat, 02 Dec 2023 11:54:17 +0100
Message-ID: <m1y1ec27ty.fsf@dazzs-mbp.home>
References: <87il7ib6cu.fsf@posteo.net> <87sf67qqmp.fsf@web.de>
 <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de>
 <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de>
 <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de>
 <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de>
 <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de>
 <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de>
 <87h6mcr8ol.fsf@posteo.net> <87r0l73029.fsf@web.de>
 <877cmdx8ud.fsf@posteo.net> <87v89hufbw.fsf@gnu.org>
 <87zfytdj86.fsf@posteo.net> <87plzo3n5o.fsf@bzg.fr>
Reply-To: Eshel Yaron <me@eshelyaron.com>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="24114"; mail-complaints-to="usenet@ciao.gmane.io"
User-Agent: Gnus/5.13 (Gnus v5.13)
Cc: jonas@bernoul.li, Michael Heerdegen <michael_heerdegen@web.de>,
 stefankangas@gmail.com, Thierry Volpiatto <thievol@posteo.net>,
 66394@debbugs.gnu.org, monnier@iro.umontreal.ca
To: Bastien Guerry <bzg@gnu.org>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 02 11:55:13 2023
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1r9NeT-00063E-Km
	for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Dec 2023 11:55:13 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1r9Ne9-00066U-Sa; Sat, 02 Dec 2023 05:54:53 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r9Ne9-00066L-82
 for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 05:54:53 -0500
Original-Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r9Ne9-0006tD-00
 for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 05:54:53 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r9NeI-00067R-74
 for bug-gnu-emacs@gnu.org; Sat, 02 Dec 2023 05:55:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Eshel Yaron <me@eshelyaron.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Sat, 02 Dec 2023 10:55:02 +0000
Resent-Message-ID: <handler.66394.B66394.170151447223479@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 66394
X-GNU-PR-Package: emacs
Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.170151447223479
 (code B ref 66394); Sat, 02 Dec 2023 10:55:02 +0000
Original-Received: (at 66394) by debbugs.gnu.org; 2 Dec 2023 10:54:32 +0000
Original-Received: from localhost ([127.0.0.1]:56760 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1r9Ndn-00066d-LW
 for submit@debbugs.gnu.org; Sat, 02 Dec 2023 05:54:32 -0500
Original-Received: from mail.eshelyaron.com ([107.175.124.16]:37154 helo=eshelyaron.com)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@eshelyaron.com>) id 1r9Ndm-00066V-2e
 for 66394@debbugs.gnu.org; Sat, 02 Dec 2023 05:54:31 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com;
 s=mail; t=1701514460;
 bh=GkOh/TnRRrMDy2H0Z/Fge14wGOTnOQ+mA35KC5Qn+oc=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=Tn8PTlHhnoNa4yMVJKnfR6Dt7F6CvZEtkq9xR7raRchw+SgiVQHx3NGpDcgE1XZgV
 BF5CyrTMt1zknBI9TSxY0a2ohH1Ayh4DTrYZwia6Bzxgf+bdweOiM662CjJsmKE2IE
 hxUrkW2GBJ19Ey3K1VdY04/E/G4RMprgulLocHf4VkKgAi84iuRvi3+cWzIVx9sDc8
 DECX6j0SqztEFIkFwjb8SXXffK2EF+7GRNLJh8QV41GzHQrNib1AnPcxwttkXjMYXV
 GRQWO9Zbi5pCca9Gy29/aXGcmKmcsRxE6SJUqitkqhjxng0BAQH9NbkYugymb0bWpq
 nJRPWlJxDJKDw==
In-Reply-To: <87plzo3n5o.fsf@bzg.fr> (Bastien Guerry's message of "Sat, 02 Dec
 2023 11:37:55 +0100")
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:275367
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/275367>

Bastien Guerry <bzg@gnu.org> writes:

> Thierry Volpiatto <thievol@posteo.net> writes:
>
>>> - C-x r s would display the preview and copy the region to the "b"
>>>   register as soon as the "b" key is hit (using read-key).
>>
>> I suggest you use M-n RET instead if you want to be sure you don't
>> overwrite a register.
>
> What I am suggesting is to store the register _as soon as_ the user
> hits the "b" key.
>
> Since the recent changes, I need to hit one additional keystroke for
> zero benefit, which is a net less when you use registers a lot.
>
> I use "a", "b", "c" registers for quick copy and paste and can easily
> remember them; when I need more, I use register-list.el.
>
>> It is what it is doing actually with minibuffer.  Hitting "a" highlight
>> register "a" and send a message "overwriting register", then you can hit
>> RET if you want to overwrite.
>
> This might be useful in some cases. I don't suggest to change this. I
> suggest to allow the previous behavior for empty registers.
>
>> I think using read-key+minibuffer would be very complicated and would
>> need much more code, this for a small benefit: Saving one key (RET).
>
> I would say this is not a small benefit.

FWIW, I second Bastien's request to restore the existing behavior as the
default, or at least provide it as an option.  I think Michael requested
that as well in the beginning of this thread.

This patch brings some nice benefits, but it also presents a regression
in terms of UX, perhaps we could avoid that or make it opt-in?  It would
also be great if there were a NEWS entry that clearly describes the user
visible changes.


Thanks,

Eshel