From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68547: [PATCH] ; Fix 'mode-line-format-right-align' with ElDoc Date: Sun, 21 Jan 2024 09:34:31 +0100 Message-ID: References: <83cytwtjiw.fsf@gnu.org> <83plxvsweh.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10701"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 68547@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 21 09:35:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rRTIP-0002Xk-QG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jan 2024 09:35:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRTIH-00038m-Ei; Sun, 21 Jan 2024 03:35:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRTIA-000384-ON for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 03:34:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRTIA-0002Nj-GW for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 03:34:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rRTID-0007fN-Ke for bug-gnu-emacs@gnu.org; Sun, 21 Jan 2024 03:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jan 2024 08:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68547-submit@debbugs.gnu.org id=B68547.170582608229439 (code B ref 68547); Sun, 21 Jan 2024 08:35:01 +0000 Original-Received: (at 68547) by debbugs.gnu.org; 21 Jan 2024 08:34:42 +0000 Original-Received: from localhost ([127.0.0.1]:36544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRTHu-0007el-2Q for submit@debbugs.gnu.org; Sun, 21 Jan 2024 03:34:42 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:42388 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRTHq-0007ea-7j for 68547@debbugs.gnu.org; Sun, 21 Jan 2024 03:34:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1705826074; bh=k1HPUAxIBZLMe7zft++K4e5E6OYxKBF5r6t2MjN0kYA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=K5NCwMNm16ARiMoLoH0J6dd9G/SE/99mPklJzrYicD6EZkPv70YBTTDJF7KPU7kS4 9Bj4TTqw01SBttASmY2OmpgJ5ohJMNn1Hj9Bhv0wP3qbB8X9lQ3oWKENvmR8q9fTGK FgCMVUxRrxeaxfRgf13/61DPQdRQ7F3/AZCQ6IZ2EZxeHYA7xlvNxVXavBIfgYCBt2 v+LSciaeX9QjKMX09wS8mpQY1vtSHA2O4DDGn/N+BnvT3T8qMXBbRQXfBupbfHkKEe 7RRv7AcAJlo8N6wAk3N5ybs+wEZSrxCRa02vdxNE3qd9lPMaiy1avMCq7wN2IfZ4XD XcDkgFAigpaZA== In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 20 Jan 2024 21:12:22 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278656 Archived-At: Hi, Jo=C3=A3o T=C3=A1vora writes: > So Eshel, if you try my patch... I tried your new patch, and it works well, AFAICT. Two suggestions: 1. This patch omits a space that would appear before the info on the mode line. I like that bit of padding, so I suggest restoring it :) 2. In `eldoc--message-in-mode-line`, `add-hook` and `remove-hook` can be called with non-nil LOCAL argument to further localize the effect, although I'm not sure that makes a real difference in practice. Best, Eshel