From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands Date: Fri, 28 Jun 2024 17:00:15 +0200 Message-ID: References: <87a5jd8hqh.fsf@gmail.com> <877ceg9546.fsf@gmail.com> <874j9k8wpo.fsf@gmail.com> <87r0cn5n2s.fsf@gmail.com> <87bk3q5ki8.fsf@gmail.com> <87r0chty5t.fsf@gmail.com> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33616"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71716@debbugs.gnu.org To: Jules Tamagnan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 28 17:01:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sND6E-0008UT-AY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jun 2024 17:01:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sND60-0003ZC-9N; Fri, 28 Jun 2024 11:01:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sND5y-0003Yi-PO for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 11:01:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sND5y-00065J-Gj for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 11:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sND5y-0005zR-Ec for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 11:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2024 15:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71716 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71716-submit@debbugs.gnu.org id=B71716.171958682022952 (code B ref 71716); Fri, 28 Jun 2024 15:01:02 +0000 Original-Received: (at 71716) by debbugs.gnu.org; 28 Jun 2024 15:00:20 +0000 Original-Received: from localhost ([127.0.0.1]:46075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sND5I-0005y7-7L for submit@debbugs.gnu.org; Fri, 28 Jun 2024 11:00:20 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:34146 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sND5G-0005xu-OU; Fri, 28 Jun 2024 11:00:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1719586817; bh=+fBzWTlmTUEHVcfk1OxhT7DI9M1MOKTa62vUPj1yZIY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ICar2CHuBTO+IilVPzyDXz7Rglv/h/GlCPfejJQLvBFHDPKeQIHw9prgiRiKePYWa BNUlAVB9o6fPAbt0CqeiU5COrzUkV/4gBPEAvZTPS1wv5adStGM1gnm7audYJx/Ahg e43HYBbManv/b2eCMy2qcG6c1BDcFCj8J+JAf4KWE91P3RCeY+W2hx1LP85T20V47C g6UIFNRcY5yln3Us80zNEkJtLZR4Vf6MiFGziP0oCEGL1EaclJmte6HMyKfBfw/WRz nFo2h6Sc8y8UpmYfFKvmGHLWy1uolJgmPpu9u1on03QeB9TgLM6Z70oav6AnKkOcwY 12BNMCI6hcoOQ== In-Reply-To: <87r0chty5t.fsf@gmail.com> (Jules Tamagnan's message of "Thu, 27 Jun 2024 22:49:02 -0700") X-Hashcash: 1:20:240628:jtamagnan@gmail.com::vySGYWXU41tZmWf0:OrQ X-Hashcash: 1:20:240628:71716@debbugs.gnu.org::Y8DCdxHjRuoJyvia:06L+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288076 Archived-At: close 71716 31.1 quit Jules Tamagnan writes: > Eshel Yaron writes: > >> Thank you, pushed to master as commit b3017e7c252, after some tweaks to >> the commit message. I've also pushed a follow up commit (9cb2a204088) >> with some minor refinements, see the commit message for details. One >> notable change is that completion-preview-partial-insert does not force >> point to the position of the preview overlay ("end") before calling the >> motion function. This makes completion-preview-insert-word behave more >> like forward-word when point is in the middle of a multi-word symbol, >> with the completion preview at the end of that symbol. I've added >> another test case that demonstrates this behavior. >> >> Could you please give it a try to make sure that everything still works >> as you expect? >> >> Thanks, >> >> Eshel > > I've taken this change around the block since yesterday and everything > seems to be working exactly as I would expect it to. Great, I'm therefore closing this bug. > I've also reviewed the cleanup that you did and tried to take some > notes, especially on the commit message. There was actually one more small issue that I now fixed in commit 5e3b94e1bec - in case completion-preview-insert-word would just move word without leaving anything inserted, it would still record an unwanted undo operation (that just inserts and deletes everything again, basically a no-op). Now we avoid recording anything in buffer-undo-list if we're only moving point. > Thanks again for all of the work that you put into creating this > packaging in the first place, helping me through my change, and > cleaning up the rough edges in the aftermath. Thank you for this nice contribution! Eshel