From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.devel Subject: Re: yet more term.el fixes #2 Date: Thu, 23 Sep 2004 07:44:50 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <200409220317.i8M3HEGK002410@scanner2.ics.uci.edu> <200409220418.i8M4IJGK005554@scanner2.ics.uci.edu> <200409221743.i8MHhSGK020804@scanner2.ics.uci.edu> <200409230214.i8N2E4GK024796@scanner2.ics.uci.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1095939923 30287 80.91.229.6 (23 Sep 2004 11:45:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 23 Sep 2004 11:45:23 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 23 13:45:12 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CAS2B-0003d8-00 for ; Thu, 23 Sep 2004 13:45:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CAS8D-00064H-C1 for ged-emacs-devel@m.gmane.org; Thu, 23 Sep 2004 07:51:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CAS87-000642-C8 for emacs-devel@gnu.org; Thu, 23 Sep 2004 07:51:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CAS85-00063q-Pw for emacs-devel@gnu.org; Thu, 23 Sep 2004 07:51:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CAS85-00063n-JI for emacs-devel@gnu.org; Thu, 23 Sep 2004 07:51:17 -0400 Original-Received: from [206.47.199.163] (helo=simmts5-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CAS1r-0006Qd-FS; Thu, 23 Sep 2004 07:44:51 -0400 Original-Received: from empanada.home ([67.70.165.30]) by simmts5-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20040923114243.ZRYJ1635.simmts5-srv.bellnexxia.net@empanada.home>; Thu, 23 Sep 2004 07:42:43 -0400 Original-Received: by empanada.home (Postfix, from userid 502) id 8973230023E; Thu, 23 Sep 2004 07:44:50 -0400 (EDT) Original-To: Dan Nicolaescu In-Reply-To: <200409230214.i8N2E4GK024796@scanner2.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 22 Sep 2004 19:14:02 -0700") User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3.50 (darwin) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:27487 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:27487 >> > (insert (string-as-unibyte (substring str i funny))) >> >> I think string-as-unibyte is also an extremely poor choice here and will >> likely lead to unexpected errors in some cases (it's a function that should >> have big warning signs all around it, like string-as-multibyte). >> >> Also calling set-buffer-multibyte is to be avoided if possible. >> >> Can you try with >> >> (insert (decode-coding-string (substring str i funny) locale-coding-system)) >> Also based on your above code, it seems that `str' is a multibyte string, >> which sounds wrong. I think that the coding-system used for the process's >> output should be `binary'. Can you see what coding-system is used for >> the process? > In term-exec-1: > (coding-system-for-read 'unknown-unix) Sorry I miss that term-exec-1. Please add to my previous patch the one below. > Did not work. What did it do? > It can be made work by binding: > (default-enable-multibyte-characters t) > when creating the buffer in make-term (so as to do what > set-buffer-multibyte used to do) But fiddling with enable-multibyte-characters is only ever going to hide the bug. Stefan