From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67702: 30.0.50; insert-register can no longer be used in minibuffer Date: Fri, 08 Dec 2023 09:27:22 +0100 Message-ID: References: <83jzpp19xg.fsf@gnu.org> <87wmtpgooa.fsf@posteo.net> <83bkb117y2.fsf@gnu.org> <837clp167l.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35947"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: thievol@posteo.net, kun.liu@gmail.com, 67702@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 08 09:28:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBWDQ-00099O-M1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Dec 2023 09:28:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBWD8-0002KG-9x; Fri, 08 Dec 2023 03:27:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBWD7-0002K8-Ht for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 03:27:49 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rBWD7-0000rQ-AX for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 03:27:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rBWDJ-0003og-P0 for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 03:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Dec 2023 08:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67702 X-GNU-PR-Package: emacs Original-Received: via spool by 67702-submit@debbugs.gnu.org id=B67702.170202406614633 (code B ref 67702); Fri, 08 Dec 2023 08:28:01 +0000 Original-Received: (at 67702) by debbugs.gnu.org; 8 Dec 2023 08:27:46 +0000 Original-Received: from localhost ([127.0.0.1]:43741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBWD2-0003nr-Pc for submit@debbugs.gnu.org; Fri, 08 Dec 2023 03:27:45 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:59530 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBWCx-0003nc-Jc for 67702@debbugs.gnu.org; Fri, 08 Dec 2023 03:27:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1702024045; bh=iQpSh0Kx0NMqcafVsSdmLUKo2l3FssTjIcIT2l6A75o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=W6mowXJQLM20LRPEBtvaW9iCMOXbSe8NqO0mhbDyOSLAYQxkEpR30qV/3ZSPLlSJg DXrqlMkFv3CQAkLymovefWTh27It/yGuo0V16QRLo/f1nFs0ZoSxhBjiA+TEdeU9fm LdYgSBoA0z8r7okY8r72vdHUuHxiYp9VmOJugaNhO4l6IiAvK38K684C9Zg7gCkgNO 9Yl1ENDTvEHar3Jd6BOd2ShRNgCjOAgdFwSc33XC+Oq1m3IXkDycsqC9GRDX9447X2 4L5BGB0oBTETvxtXy5RFpnSHguOmXv+7wW5moAzp/FF0D9fW+yw5cWlVC+Yxe/tEed MLdCujf4WOOeQ== In-Reply-To: <837clp167l.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Dec 2023 09:52:46 +0200") X-Hashcash: 1:20:231208:67702@debbugs.gnu.org::yw/pMr5tUPuxkuuS:EhKR X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275737 Archived-At: Eli Zaretskii writes: >> From: Eshel Yaron >> >> >> > I guess register-read-with-preview should temporarily bind >> >> > enable-recursive-minibuffers to a non-nil value? >> >> >> >> Yes, do you want me to install this change? >> > >> > If you think that's the correct solution, sure. >> >> FWIW, I think it's not the right solution. As I wrote in bug#66394, I >> think it's wrong to involve the minibuffer in reading registers in any >> way. `enable-recursive-minibuffers` would make this less broken, but >> only slightly. > > I'm not sure I understand: if we put aside the fundamental opposition > to using read-from-minibuffer, what problems will be left if we > temporarily enable recursive-minibuffers while prompting for the > register? Concretely this is still worse because starting a recursive minibuffer hides the previous minibuffer. So you no longer see what you're operating on. There are other problems that I mentioned in bug#66394, and there's also the disadvantage that `read-from-minibuffer` switches windows, which is redundant in this case. >> It's up to you maintainers to decide, I think. Following your request, >> I've proposed a patch that reverts Thierry's changes, and implements the >> parts I find useful in a clean and backward compatible way. > > Thierry said your patch was incomplete. Well, I requested some elaboration on that comment. Still waiting. > And I wonder why we need to completely revert his changes. My > suggestion was to allow both, controlled by user option. That's basically what my patch does, it even makes Thierry's preferred behavior (confirmation before overwriting registers) the default, it just doesn't use the minibuffer for that. AFAIU the goal of Thierry's patch wasn't to use the minibuffer, that's an implementation detail, one with problematic consequences. > Then we could see what users prefer, and make the decision: whether to > keep both or just one, and which one. I very much prefer this path > forward than continuing to argue now which of the two ways is the only > one that's correct. >> > If it's unrelated, then please go ahead and install your changes in >> > that discussion. In any case, perhaps you could help Eshel improve >> > and polish his additions, which AFAIU are supposed to provide an >> > optional behavior more similar to the previous one. >> >> That'd be nice, thanks. > > Agreed. But again: please consider reworking your patch such that it > allows using the minibuffer as optional behavior. After all, using > the minibuffer has also advantages, not just disadvantages. I don't see these advantages. Again, I think this is just an implementation detail, and my patch provides a better implementation. If someone would spell out these advantages, I could look into it when I have the time. Eshel