all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo <sdl.web@gmail.com>
To: 6412@debbugs.gnu.org
Subject: bug#6412: 23.2; [patch] nXML indentation bug
Date: Sun, 13 Jun 2010 15:27:27 +0100	[thread overview]
Message-ID: <m1typ7uhww.fsf@cam.ac.uk> (raw)
In-Reply-To: <m1y6ejujda.fsf@cam.ac.uk>

[-- Attachment #1: Type: text/plain, Size: 88 bytes --]

Please ignore the patch in previous email (sorry for this). Here is the
correct patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-nxml-indent-line-to-be-consistent-with-other-mod.patch --]
[-- Type: text/x-patch, Size: 1486 bytes --]

From 3d8a976a0edad1b8e099a108320f60622d168ffb Mon Sep 17 00:00:00 2001
From: Leo <sdl.web@gmail.com>
Date: Sun, 13 Jun 2010 14:58:47 +0100
Subject: [PATCH] Fix nxml-indent-line to be consistent with other modes (#6412)

Patch sent to http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6412.
---
 lisp/nxml/nxml-mode.el |   18 ++++++++----------
 1 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/lisp/nxml/nxml-mode.el b/lisp/nxml/nxml-mode.el
index 8919d92..5e9fd8c 100644
--- a/lisp/nxml/nxml-mode.el
+++ b/lisp/nxml/nxml-mode.el
@@ -1371,16 +1371,14 @@ of the inserted start-tag or nil if none was inserted."
 (defun nxml-indent-line ()
   "Indent current line as XML."
   (let ((indent (nxml-compute-indent))
-	(from-end (- (point-max) (point))))
-    (when (and indent
-	       (/= indent (current-indentation)))
-      (beginning-of-line)
-      (let ((bol (point)))
-	(skip-chars-forward " \t")
-	(delete-region bol (point)))
-      (indent-to indent)
-      (when (> (- (point-max) from-end) (point))
-	(goto-char (- (point-max) from-end))))))
+	(from-end (- (point-max) (point)))
+	(beg (progn (forward-line 0) (point))))
+    (skip-chars-forward " \t")
+    (when (and indent (/= indent (current-indentation)))
+      (delete-region beg (point))
+      (indent-to indent))
+    (when (> (- (point-max) from-end) (point))
+      (goto-char (- (point-max) from-end)))))
 
 (defun nxml-compute-indent ()
   "Return the indent for the line containing point."
-- 
1.7.0.4


[-- Attachment #3: Type: text/plain, Size: 5 bytes --]


Leo

  reply	other threads:[~2010-06-13 14:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-13 13:56 bug#6412: 23.2; [patch] nXML indentation bug Leo
2010-06-13 14:27 ` Leo [this message]
2010-06-14  1:43   ` Stefan Monnier
2010-06-14  8:15     ` Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1typ7uhww.fsf@cam.ac.uk \
    --to=sdl.web@gmail.com \
    --cc=6412@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.