From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72759: 31.0.50; Emacs hangs with open-paren-in-column-0-is-defun-start set to nil Date: Fri, 23 Aug 2024 10:33:55 +0200 Message-ID: References: <868qwou8pv.fsf@gnu.org> <861q2gu56u.fsf@gnu.org> <86msl4slwv.fsf@gnu.org> <86ed6gsfm3.fsf@gnu.org> <86a5h4sast.fsf@gnu.org> <86jzg7rals.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25071"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72759@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 23 10:34:35 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shPkf-0006Lq-Rw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Aug 2024 10:34:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shPkP-0005CT-5R; Fri, 23 Aug 2024 04:34:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shPkN-0005CH-L9 for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 04:34:15 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shPkN-0007nF-2T for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 04:34:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=WpUKWAZRUcup3ZosqHgSWe5oB4PeiA4GxSarZrA+XNw=; b=ETeOe+E94xR6OdXWLl57bHhwXUxsRlqoyuJ5nu9jEg4DuGXCj79S7CcIjQzHAvpPtMJb3qWi9u9CMgHoZRBVg/efpxJoUxqh01bQQFz7ueq92dGb6Fhf2qL6q1jc0/NPyeF8QX9FaII2gFlAl/vXFpUodSvjWFEuifnWdR5GeEea6Q0Py1TsfUGUHXogczyApoeFIpVv7h6WAUnSEdXIV6tLPrVxtIya55pMwWKRvuGGLZQzpxhhwPlpC39qfQZGEQE0h2KYLYWhKwRDXthjPLVZ0axiH8pbBjy6BWxnydnt1KZtGnmInFzjJIfSKa7vKCitCM5ZE6uiswpvNDLw8w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shPl7-0000Gz-UT for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 04:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2024 08:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72759 X-GNU-PR-Package: emacs Original-Received: via spool by 72759-submit@debbugs.gnu.org id=B72759.17244020881016 (code B ref 72759); Fri, 23 Aug 2024 08:35:01 +0000 Original-Received: (at 72759) by debbugs.gnu.org; 23 Aug 2024 08:34:48 +0000 Original-Received: from localhost ([127.0.0.1]:38949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shPkt-0000GI-Jh for submit@debbugs.gnu.org; Fri, 23 Aug 2024 04:34:47 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:55066 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shPkq-0000G6-Ue for 72759@debbugs.gnu.org; Fri, 23 Aug 2024 04:34:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1724402037; bh=qdqv2ex/6XIANn/OacCHT54fvOIWY42R/eSKeEcTbBI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=xprKdVbhgSkzc1RJdpYrRu3Esqi38Fml/axT0mexoCL0uPgeai5CHzO9COhGvCXVS VT7/SAd4xF/tghyu1W02DZFQBC3FSRa2/0+1PaZBFbjwx9Tf7Q54ULBZpkX+3BWagl ufaLHITfbRJhMidPhkr6WkWkwCHgrtNaqBK0AG76Lc/XRu1NiI9ndHv1QM3xvMN0nV qnclsO4Dafq2cA9M4lMM3XTXMcS5UM8tj0w5WXMF5NJ7xYOiAkGpaRG2q9mvbEvbbY pjLniga7J0AC8MLLb99w/2doGkVtFVYshUUWO7dW6FlX5J0DGvy03Zh0eivErpmLOl QaC7r01M/CLPg== In-Reply-To: <86jzg7rals.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Aug 2024 09:56:15 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290586 Archived-At: Eli Zaretskii writes: >> From: Eshel Yaron >> Cc: 72759@debbugs.gnu.org >> Date: Fri, 23 Aug 2024 07:54:25 +0200 >> >> Hi Eli, >> >> Eli Zaretskii writes: >> >> >> >> diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el >> >> >> index 949ca6b74ad..65226d8ee44 100644 >> >> >> --- a/lisp/emacs-lisp/checkdoc.el >> >> >> +++ b/lisp/emacs-lisp/checkdoc.el >> >> >> @@ -981,7 +981,7 @@ checkdoc-next-docstring >> >> >> Return nil if there are no more doc strings." >> >> >> (let (found) >> >> >> (while (and (not (setq found (checkdoc--next-docstring))) >> >> >> - (beginning-of-defun -1))) >> >> >> + (beginning-of-defun-raw -1))) >> >> >> found)) >> >> > I'm trying to understand what kind of behavior change could be caused >> > by your proposed change, which is why what beginning-of-defun-raw does >> > and beginning-of-defun doesn't is important, especially if some user >> > options can affect that. E.g., does anything change in this scenario >> > if defun-prompt-regexp is non-nil? >> >> This change is the correct also when defun-prompt-regexp is non-nil. >> Take a look at beginning-of-defun, it just calls beginning-of-defun-raw >> after possibly pushing a mark, and then it calls beginning-of-line. >> We're not interested in pushing a mark here, neither do we want to move >> back to beginning of the line after each call (that yields an infloop), >> so beginning-of-defun-raw fits the bill precisely. > > Thanks, feel free to install this, then. Thank you, is this OK for the release branch or would the master branch be better? Eshel