all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo <sdl.web@gmail.com>
To: 8309@debbugs.gnu.org
Cc: Chong Yidong <cyd@stupidchicken.com>
Subject: bug#8309: 24.0.50; Remove leftover (require 'wid-edit)
Date: Mon, 21 Mar 2011 14:35:20 +0800	[thread overview]
Message-ID: <m1sjuh2d7b.fsf@gmail.com> (raw)

It looks to me since revno: 103251:

,----[ 103251 ]
| message:
|   Use simple buttons, instead of widget buttons, in vc-log.
|   
|   * lisp/vc/vc.el (vc-print-log-setup-buttons): Instead of using the
|   widget library for buttons, just use button.el.
|   
|   * lisp/vc/log-view.el (log-view-mode-map): Don't inherit from
|   widget-keymap.
`----

(require 'wid-edit) is no longer needed for log-view.el. Any objection
to this patch:

=== modified file 'lisp/vc/log-view.el'
--- lisp/vc/log-view.el	2011-02-14 01:49:24 +0000
+++ lisp/vc/log-view.el	2011-03-21 06:34:34 +0000
@@ -121,9 +121,6 @@
   :group 'pcl-cvs
   :prefix "log-view-")
 
-;; Needed because log-view-mode-map inherits from widget-keymap.  (Bug#5311)
-(require 'wid-edit)
-
 (easy-mmode-defmap log-view-mode-map
   '(
     ;; FIXME: (copy-keymap special-mode-map) instead



Leo





             reply	other threads:[~2011-03-21  6:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21  6:35 Leo [this message]
2011-03-21 14:51 ` bug#8309: 24.0.50; Remove leftover (require 'wid-edit) Stefan Monnier
2011-03-21 15:28   ` Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1sjuh2d7b.fsf@gmail.com \
    --to=sdl.web@gmail.com \
    --cc=8309@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.