all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo <sdl.web@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Move sha1 to C?
Date: Mon, 23 May 2011 16:44:53 +0800	[thread overview]
Message-ID: <m1sjs57qm2.fsf@th041094.ip.tsinghua.edu.cn> (raw)
In-Reply-To: jwv7h9i9pqc.fsf-monnier+emacs@gnu.org

On 2011-05-23 09:23 +0800, Stefan Monnier wrote:
> Fine by me.  3 should also include "gut sha1.el's content" so that
> loading it won't end up overwriting the C implementation with the old
> Elisp code.

In the patch attached in last post, feature sha1 is provided so
(require 'sha1) should not load sha1.el but if people insist in using
(load "sha1") then the primitive is overwritten. I hope this is OK.

>
>> Should the signature of sha1 stay as is or change to be similar to md5?
>>    (md5 OBJECT &optional START END CODING-SYSTEM NOERROR)
>
> I don't have any opinion on this.  The only thing I consider important
> is to signal an error if the hashed text contains any
> non-byte character.

OK.

Leo




  reply	other threads:[~2011-05-23  8:44 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-21  6:37 Move sha1 to C? Leo
2011-05-22 19:04 ` Stefan Monnier
2011-05-22 20:02   ` Leo
2011-05-23  1:23     ` Stefan Monnier
2011-05-23  8:44       ` Leo [this message]
2011-05-23 12:04         ` Stefan Monnier
2011-05-23 13:21           ` Leo
2011-05-23 13:27             ` Stefan Monnier
2011-05-23 13:34               ` Leo
2011-05-23 13:57                 ` Stefan Monnier
2011-05-23 18:14                   ` Leo
2011-05-23 19:15                     ` Stefan Monnier
2011-05-23 22:10                     ` Paul Eggert
2011-05-24  4:09                       ` Leo
2011-05-24 10:01                         ` Eli Zaretskii
2011-05-24 14:24                           ` Leo
2011-05-24 22:01                           ` Richard Stallman
2011-05-24  5:09                       ` Thien-Thi Nguyen
2011-05-23 14:30                 ` Eli Zaretskii
2011-05-23 17:47                   ` Leo
2011-05-23 18:12                     ` Eli Zaretskii
2011-05-23 18:23                       ` Leo
2011-05-23 19:21                         ` Eli Zaretskii
2011-05-23  7:21     ` Eli Zaretskii
2011-05-23  8:30       ` Leo
2011-05-23 15:27         ` Chong Yidong
2011-05-23 17:14           ` Leo
2011-05-23 17:38       ` Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1sjs57qm2.fsf@th041094.ip.tsinghua.edu.cn \
    --to=sdl.web@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.