all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo <sdl.web@gmail.com>
To: 10937@debbugs.gnu.org
Subject: bug#10937: 24.0.94; fix savehist-printable
Date: Sun, 04 Mar 2012 17:15:44 +0800	[thread overview]
Message-ID: <m1sjho681r.fsf@gmail.com> (raw)

In savehist-printable, strings are not necessary printable. They can
contain anything in their properties. Because of this I have kill-ring
emptied for almost every restart of emacs.

I propose:

diff --git a/lisp/savehist.el b/lisp/savehist.el
index c1515fa4..a3ba9f1a 100644
--- a/lisp/savehist.el
+++ b/lisp/savehist.el
@@ -369,7 +369,7 @@ (defun savehist-printable (value)
   "Return non-nil if VALUE is printable."
   (cond
    ;; Quick response for oft-encountered types known to be printable.
-   ((stringp value))
+   ((equal-including-properties value (substring-no-properties value)))
    ((numberp value))
    ((symbolp value))
    (t

or just remove (stringp value) and let the default handle it.

Leo





             reply	other threads:[~2012-03-04  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-04  9:15 Leo [this message]
2012-03-09 18:12 ` bug#10937: 24.0.94; fix savehist-printable Leo
2012-03-21 17:55 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1sjho681r.fsf@gmail.com \
    --to=sdl.web@gmail.com \
    --cc=10937@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.