From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Magnus Henoch Newsgroups: gmane.emacs.bugs Subject: bug#17636: Implement SCRAM-SHA-1 SASL mechanism Date: Thu, 05 Jun 2014 10:25:26 +0100 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1401961009 17756 80.91.229.3 (5 Jun 2014 09:36:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Jun 2014 09:36:49 +0000 (UTC) Cc: 17636@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 05 11:36:42 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WsU6D-0001UR-7i for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jun 2014 11:36:41 +0200 Original-Received: from localhost ([::1]:39540 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsU6C-0008Ij-NJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jun 2014 05:36:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsTw1-0000fZ-Ed for bug-gnu-emacs@gnu.org; Thu, 05 Jun 2014 05:26:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsTvv-0001Zf-ID for bug-gnu-emacs@gnu.org; Thu, 05 Jun 2014 05:26:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsTvv-0001ZU-72 for bug-gnu-emacs@gnu.org; Thu, 05 Jun 2014 05:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WsTvu-0003MA-IS for bug-gnu-emacs@gnu.org; Thu, 05 Jun 2014 05:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Magnus Henoch Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jun 2014 09:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17636 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17636-submit@debbugs.gnu.org id=B17636.140196033812860 (code B ref 17636); Thu, 05 Jun 2014 09:26:02 +0000 Original-Received: (at 17636) by debbugs.gnu.org; 5 Jun 2014 09:25:38 +0000 Original-Received: from localhost ([127.0.0.1]:44751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsTvV-0003LM-Sb for submit@debbugs.gnu.org; Thu, 05 Jun 2014 05:25:38 -0400 Original-Received: from mail-wg0-f43.google.com ([74.125.82.43]:35176) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WsTvT-0003L5-2e for 17636@debbugs.gnu.org; Thu, 05 Jun 2014 05:25:35 -0400 Original-Received: by mail-wg0-f43.google.com with SMTP id l18so727748wgh.26 for <17636@debbugs.gnu.org>; Thu, 05 Jun 2014 02:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Xcgfgkin3q7fbul/p0IjuErR93rMt7LgLhEGwxhhnk4=; b=iaO1KrcRe3QMIzjoVkRLC7RQWG4fEkIqZW2rosMi2KzxFGoPyEqdn2jw8RBbH/XINe DCNa0kHkkIlXSHQTenSmP14V+LGHBKhDleVBJP61/MbATv/OQHa6tZupkzzk1HS4liuz itkr0c0sMjR3hOphDWlB7KAQKMj2k7L+bDPXV7Wqb9RYaXX2MhKi1Q/kP1C2yo2E5UUo PaepqK2DiwjPKM2imR6zv+I3KNgSVmvC/OARraB6oifeFIpKra4glkUGfLdkYMnJBMF3 aaN2gwsduO3qeM0663uiN1IAhGlqnILnX6QrbXNX0uqk1TfU1a0GBBm6fX0Cu6SQjVH2 21FQ== X-Received: by 10.14.211.66 with SMTP id v42mr7098034eeo.1.1401960329210; Thu, 05 Jun 2014 02:25:29 -0700 (PDT) Original-Received: from poki-sona-sin.local ([83.218.151.42]) by mx.google.com with ESMTPSA id cj41sm13049284eeb.34.2014.06.05.02.25.27 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jun 2014 02:25:28 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 01 Jun 2014 10:20:26 -0400") User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4.50 (darwin) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90034 Archived-At: Stefan Monnier writes: >>>> SCRAM-SHA-1 requires an implementation of HMAC-SHA1, so I added a module >>>> for that, too. >>> Do we really need a whole file for those three lines? >> Good point. Should I just put it in hmac-md5.el? I can't think of any >> more logical place for it. > > If I could choose, I'd merge all hmac-*.el into a single file. I just discovered that there is a second HMAC implementation in Emacs: gnus/rfc2104.el. Unlike hmac-*, it doesn't use a macro to make a specific function for each hash, but just takes the hash function as an argument. I'll try to see if that makes any significant speed difference, and if one implementation could be reasonably deprecated in favour of the other. (Incidentally, all but one usage of rfc2104-hash are in places where the SASL library could be used instead: nnimap.el, smtpmail.el, imap.el.) Regards, Magnus