From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Unknown Newsgroups: gmane.emacs.bugs Subject: bug#43520: 27.1; [PATCH] Add support for make-pointer-invisible on macOS Date: Sat, 19 Sep 2020 20:31:05 +0200 Message-ID: References: Reply-To: =?UTF-8?Q?Reply-to=3A_Daniel_Mart=C3=83=C2=ADn_=3Cmardani29=40yahoo=2Ees?= =?UTF-8?Q?=3E=0A?= Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7748"; mail-complaints-to="usenet@ciao.gmane.io" To: 43520@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 19 20:32:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJhef-0001t7-5R for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 20:32:13 +0200 Original-Received: from localhost ([::1]:54956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJhed-0001e5-Qj for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 14:32:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49676) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJheW-0001dz-7J for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 14:32:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJheU-0008K5-5T for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 14:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJheU-0005aK-1q for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 14:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Sep 2020 18:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 43520 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160054028621425 (code B ref -1); Sat, 19 Sep 2020 18:32:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Sep 2020 18:31:26 +0000 Original-Received: from localhost ([127.0.0.1]:48093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJhdt-0005ZT-TY for submit@debbugs.gnu.org; Sat, 19 Sep 2020 14:31:26 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJhdp-0005ZJ-Ct for submit@debbugs.gnu.org; Sat, 19 Sep 2020 14:31:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJhdm-0001bn-0s for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 14:31:19 -0400 Original-Received: from sonic312-26.consmr.mail.ir2.yahoo.com ([77.238.178.97]:35821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJhdj-0008Gr-Q0 for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 14:31:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1600540273; bh=p3qvVKor6l0jku8IIqz0Wi3uef/YgVaxBC77TazV2eo=; h=From:To:Subject:Date:References:From:Subject; b=iwMZs9tEwv3abWlABeJehS9L333I2BsoolEjyW+Ty38c1BFXKRm6RcHzEME5Niese4Qrh8s3uZOuFrFOIENn/qeEj/qNNJpIoMpxFgn1urwUOO1AWF3NSjV6SxiQUHV7UJb9QP+ZqpAbxoUMe/SK7XntgBDCZ0/p0ong0o68wT2TUrCpnnJnuzbX2h6Twm5pw72HArCf1V4HPGfxuF8oCWuUdUGaHu4NFuBbL8ZfkVHt3OiXt6FWO7gfA7TF2RYuvWw70ah8+OS/xaNxx2CC/i9t6RBEg5zdloVguvRYGhhT3D6YRZKWQ2VffCnEzgWy5XGb9S/l/nKDuRyMcL+zRw== X-YMail-OSG: r02h1jEVM1nPrvkZqj_rbtw8ycKg3Y8AMiC0WYf3E2K7EMe14EmN4seE16ugnjc dB1uwsIbunH4PWN7E3o.vSTzxrwVeMtk1_Nt78bHn6cWQcUEZtN.ro8CEiXEp3XcsMsY6THxcXpP t8W7NCaAWLDJ0fTDYpfIBKL9aRAznSsLJnDMjIy7Hfs2Eg1u6Y5geBlZkS6kVwZfwwFv2aLO.hXG wdfj0JV8n.zaeJhK6oNs8CUsvE6xPJa32lom_UVueWWexPsZDlwA6ACGfpivD_ID4TZU0XWdYJvG KilntF0Pi_KaiAx31P3rjZlFE5_34g2GvucIhZ5blQxOeLN93r67fKKC4W4x3MsbgCK.flHf9qAb S9JbJu4Z85GvhL3PtZaY.UcBSZh9Hn9dQLxHHdzC_ryzjHWG_te._OQzGF3cD_s2CoL.kGJo_h6T KGH6pQI8MPJfq8QJxy73PI9F2fc1MkNIGDrROJjifQySp5MEm2rXZHfQgOnvTqD4CIuiSTStKsu0 7lytOg1JxK8QjRs4sgI0Eax4LIyOuylnxF1ttR7A8tILz.0D9r1ffhdJF7V0C8YG.orPyZej07hX gB7ASwKUAvAKWNst8iGruf2pXEMDGhuZQkqp2G1VI1cZzC_yDhMnq1P1hUBKjxZ1uoxgyFm.w1rv YexL9gDjUTN9BRWieWhtHcGCTlR9kZUEfSO20jT8A4rUk3yXjcRtGa2jzYy72rYSgp39r3pF6edC wPfwQOHI7_YLBO8h3sIcaY_ENbwdAoKx5hJK5eOgPRfHEhj5cymn0a9YmrVYqyfrutWKlk1bu6tl rqJLWbo3_Qr9WgV9X8NMWovYcw4bFK7368nokdIyyO Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ir2.yahoo.com with HTTP; Sat, 19 Sep 2020 18:31:13 +0000 Original-Received: by smtp415.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID a4f18489f1075978ca53c4d1491abe5f; Sat, 19 Sep 2020 18:31:11 +0000 (UTC) X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=77.238.178.97; envelope-from=mardani29@yahoo.es; helo=sonic312-26.consmr.mail.ir2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/19 14:31:13 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Original-From: Xref: news.gmane.io gmane.emacs.bugs:188425 Archived-At: --=-=-= Content-Type: text/plain The following patch adds proper support for make-pointer-invisible on macOS. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Honor-make-pointer-invisible-on-macOS.patch >From ad92732d28a484d538a4e98331878a0f60e07fd2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Sat, 19 Sep 2020 20:19:57 +0200 Subject: [PATCH] Honor make-pointer-invisible on macOS * src/nsterm.m: Call [NSCursor setHiddenUntilMouseMoves:] with the correct argument, depending on variable make-pointer-invisible. --- etc/NEWS | 3 +++ src/nsterm.m | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 26aa030391..363d843265 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -145,6 +145,9 @@ your init file: (setq frame-title-format '(multiple-frames "%b" ("" invocation-name "@" system-name))) +--- +** The variable 'make-pointer-invisible' is now honored on macOS. + * Editing Changes in Emacs 28.1 diff --git a/src/nsterm.m b/src/nsterm.m index 26059ab67c..f6a36c8fdc 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -6449,7 +6449,7 @@ most recently updated (I guess), which is not the correct one. */ if (nsEvArray == nil) nsEvArray = [[NSMutableArray alloc] initWithCapacity: 1]; - [NSCursor setHiddenUntilMouseMoves: YES]; + [NSCursor setHiddenUntilMouseMoves:! NILP (Vmake_pointer_invisible)]; if (hlinfo->mouse_face_hidden && FIXNUMP (Vmouse_highlight)) { -- 2.28.0 --=-=-=--