From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71716: [PATCH] Add new completion-preview-insert-{word, sexp} commands Date: Thu, 27 Jun 2024 20:31:59 +0200 Message-ID: References: <87a5jd8hqh.fsf@gmail.com> <877ceg9546.fsf@gmail.com> <874j9k8wpo.fsf@gmail.com> <87r0cn5n2s.fsf@gmail.com> <87bk3q5ki8.fsf@gmail.com> <86r0cjdjpz.fsf@mail.linkov.net> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4294"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71716@debbugs.gnu.org, Jules Tamagnan To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 27 20:56:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMuI3-0000o9-Ln for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jun 2024 20:56:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMuHq-0005Rn-LE; Thu, 27 Jun 2024 14:56:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMuHo-0005RU-Sg for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 14:56:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMuHo-000595-KX for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 14:56:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMuHq-0001X0-Eb for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 14:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71716 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71716-submit@debbugs.gnu.org id=B71716.17195145075825 (code B ref 71716); Thu, 27 Jun 2024 18:56:02 +0000 Original-Received: (at 71716) by debbugs.gnu.org; 27 Jun 2024 18:55:07 +0000 Original-Received: from localhost ([127.0.0.1]:43352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMuGx-0001Vs-1L for submit@debbugs.gnu.org; Thu, 27 Jun 2024 14:55:07 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:33624 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMuGu-0001Vh-DQ for 71716@debbugs.gnu.org; Thu, 27 Jun 2024 14:55:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1719514500; bh=66oaCTO1GlSFUg9iJy+PNZQi3JSIxAH6uC+uyEwsC2M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=wHlN21O8aNWgdtZXQ1f6rKjQe4xsu/5q4k5anWEd6SF9ZROWgByS1r3umfIEGT3gC a+XUME52xfq/82xDxymVpfRnlV/p2nHF6MwwLSTmZ+yNhf3QC8Hx2ta94qab2+Zb0W gs2Jg9uVklhNuOzYda5GMmpfRN98flACwsk6RYBHUiXZ0U1L5ZXSV+fo08dZ3EEhaL igLhYAAnHm3ALNTAre40JTVF0pPJP63YqcXmlEQd5KIKNQw/5N4EAzg5LpzXjc5Lih 0J19+YvuZTVk9+jAnDuB5Zjbklh9YjmcipJQlQUDBw7o2F2GD6kvHOYcTvIAKwjxdx HiPZGyi05IwUg== In-Reply-To: <86r0cjdjpz.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 27 Jun 2024 09:33:04 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288034 Archived-At: Hi Juri, Juri Linkov writes: >> +;; This command is not bound by default, but you may want to bind it to >> +;; M-f (or remap `forward-word') in `completion-preview-active-mode-map' >> +;; since it's very much like a `forward-word' that also moves "into" the >> +;; completion preview. > > Also this is very much like 'C-w' in Isearch (isearch-yank-word-or-char), > and 'C-w' does nothing without the region, only raises an error > "The mark is not set now, so there is no region". > So 'C-w' could be bound by default. Thanks, that's an interesting suggestion. I prefer not to bind completion-preview-insert-word by default right away, because Completion Preview mode should by default be unintrusive, and bindings in completion-preview-active-mode-map override bindings that users may have in place when the preview appears. But if you use this binding and find it convenient, feel free to add such a recommendation to the commentary. Best, Eshel