Re: /srv/bzr/emacs/trunk r107337: Protect fileio.c primitives against invalid file handler return values.

Re: /srv/bzr/emacs/trunk r107337: Protect fileio.c primitives against invalid file handler return values.

[Leo]

Thank you for fixing the crash.

On 2012-02-19 17:58 +0800, Chong Yidong wrote:
> +      error ("Invalid handler in `file-name-handler-alist'");

By looking at the doc-string of file-name-handler-alist, it seems
'("asdf" . ignore) is perfectly legitimate. Why is it invalid?

Thanks,
Leo

Re: /srv/bzr/emacs/trunk r107337: Protect fileio.c primitives against invalid file handler return values.

[Chong Yidong]

Leo <sdl.web@gmail.com> writes:

> Thank you for fixing the crash.
>
> On 2012-02-19 17:58 +0800, Chong Yidong wrote:
>> +      error ("Invalid handler in `file-name-handler-alist'");
>
> By looking at the doc-string of file-name-handler-alist, it seems
> '("asdf" . ignore) is perfectly legitimate. Why is it invalid?

This is explained in more detail in (elisp)Magic File Names:

  The handler function must handle all of the above operations, and
  possibly others to be added in the future.  It need not implement all
  these operations itself--when it has nothing special to do for a
  certain operation, it can reinvoke the primitive, to handle the
  operation "in the usual way."  It should always reinvoke the primitive
  for an operation it does not recognize.

If the handler function returns an object of the wrong type, and that is
not caught, Emacs is liable to crash if that return value is used in C
code.

Re: /srv/bzr/emacs/trunk r107337: Protect fileio.c primitives against invalid file handler return values.

[Leo]

On 2012-02-20 10:02 +0800, Chong Yidong wrote:
> If the handler function returns an object of the wrong type, and that is
> not caught, Emacs is liable to crash if that return value is used in C
> code.

Thank you.

Leo

Re: /srv/bzr/emacs/trunk r107337: Protect fileio.c primitives against invalid file handler return values.

[Stefan Monnier]

> If the handler function returns an object of the wrong type, and that is
> not caught, Emacs is liable to crash if that return value is used in C
> code.

Note that such a crash would denote a bug in the C code (triggered by
a bug in the file-handler, of course, but a separate bug nevertheless).


        Stefan