From: Leo Liu <sdl.web@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 13999@debbugs.gnu.org, Carsten Bormann <cabo@tzi.org>
Subject: bug#13999: 24.3.50; rng-validate-while-idle -> (error "Selecting deleted buffer")
Date: Sat, 23 Mar 2013 11:28:30 +0800 [thread overview]
Message-ID: <m1r4j6okv5.fsf@gmail.com> (raw)
In-Reply-To: <jwv7gl24upo.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 19 Mar 2013 23:29:39 -0400")
On 2013-03-20 11:29 +0800, Stefan Monnier wrote:
> I think it's still worthwhile to defensively make
> rng-validate-while-idle check that the buffer is still live, since the
> other problem may be anywhere in some unrelated code (potentially
> external to Emacs) that let-binds kill-buffer-hook (for example).
Let-binding kill-buffer-hook is also a source of problems like this bug
report. There are three places in emacs that do this:
international/mule.el
emacs-lisp/edebug.el
gnus/mml.el
Looks like a really bad idea.
Most uses of kill-buffer-hook are cleanup routines. Let-bind the hook to
nil has a high probability of leaving things in an inconsistent state.
I think we should find a way to fix the three occurrences in emacs and
put a note in kill-buffer-hook's doc-string.
Leo
next prev parent reply other threads:[~2013-03-23 3:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 15:35 bug#13999: 24.3.50; rng-validate-while-idle -> (error "Selecting deleted buffer") Carsten Bormann
2013-03-19 15:55 ` Leo Liu
2013-03-19 20:51 ` Stefan Monnier
2013-03-20 0:33 ` Leo Liu
2013-03-20 3:29 ` Stefan Monnier
2013-03-20 4:30 ` Leo Liu
2013-03-22 9:55 ` Leo Liu
2013-03-22 13:36 ` Stefan Monnier
2013-03-22 14:39 ` Leo Liu
2013-03-22 17:34 ` Stefan Monnier
2013-03-23 1:47 ` Leo Liu
2013-03-23 7:54 ` Carsten Bormann
2013-03-23 14:13 ` Leo Liu
2013-03-23 3:28 ` Leo Liu [this message]
2013-03-23 16:10 ` Stefan Monnier
2013-03-24 6:51 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1r4j6okv5.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=13999@debbugs.gnu.org \
--cc=cabo@tzi.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.