bug#8699: 23.3.50; [PATCH] Allow empty regions in transpose-region

bug#8699: 23.3.50; [PATCH] Allow empty regions in transpose-region

[Leo]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

I found this odd primitive transpose-regions (which has not seen much
use anywhere). I tried to use it a bit and found the annoying error when
one of the two regions is empty.

I wonder if the attached patch makes sense. Thanks.

Leo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Allow-empty-regions-in-transpose-region.patch --]
[-- Type: text/x-diff, Size: 871 bytes --]

From 56cee3783dd30eaaf0b36f2fd8fa85525b6c4f2c Mon Sep 17 00:00:00 2001
Date: Sat, 14 May 2011 19:27:33 +0800
Subject: [PATCH] Allow empty regions in transpose-region

---
 src/editfns.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/editfns.c b/src/editfns.c
index feae8316..1022b944 100644
--- a/src/editfns.c
+++ b/src/editfns.c
@@ -4411,8 +4411,9 @@ Transposing beyond buffer boundaries is an error.  */)
 
   if (start2 < end1)
     error ("Transposed regions overlap");
-  else if (start1 == end1 || start2 == end2)
-    error ("Transposed region has length 0");
+  /* Nothing to change for adjacent regions with one being empty */
+  else if ((start1 == end1 || start2 == end2) && end1 == start2)
+    return Qnil;
 
   /* The possibilities are:
      1. Adjacent (contiguous) regions, or separate but equal regions
-- 
1.7.5-rc2

bug#8699: 23.3.50; [PATCH] Allow empty regions in transpose-region

[Leo]

On 2011-05-19 16:07 +0800, Leo wrote:
> Date: Sat, 14 May 2011 19:27:33 +0800
> Subject: [PATCH] Allow empty regions in transpose-region
>
> ---
>  src/editfns.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)

No one seems to object to this patch. So I will put it in trunk later
today.

Thanks.
Leo

bug#8699: 23.3.50; [PATCH] Allow empty regions in transpose-region

[Leo]

version 24.1