From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Mon, 04 Dec 2023 08:57:47 +0100 Message-ID: References: <87il7ib6cu.fsf@posteo.net> <87r0l73029.fsf@web.de> <877cmdx8ud.fsf@posteo.net> <87sf50s1gh.fsf@posteo.net> <83o7ficesp.fsf@gnu.org> <878r6leh9d.fsf@posteo.net> <83il5pbnmh.fsf@gnu.org> <87zfz1cz7s.fsf@posteo.net> <83bkbc7j1o.fsf@gnu.org> <8734wov2wv.fsf@posteo.net> <83v89j6arv.fsf@gnu.org> <87cyvpf8y6.fsf@posteo.net> <83plzp82mb.fsf@gnu.org> <87fs0jtkue.fsf@posteo.net> <87a5qrtepm.fsf@posteo.net> <837clv6sga.fsf@gnu.org> <87r0k2pgq6.fsf@posteo.net> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31584"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: michael_heerdegen@web.de, Eli Zaretskii , stefankangas@gmail.com, monnier@iro.umontreal.ca, 66394@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 04 08:59:01 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rA3r2-0007xN-Nm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Dec 2023 08:59:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rA3qu-0005Nt-D1; Mon, 04 Dec 2023 02:58:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rA3qt-0005Nl-Hh for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2023 02:58:51 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rA3qt-0000kL-AD for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2023 02:58:51 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rA3r3-0002zt-LG for bug-gnu-emacs@gnu.org; Mon, 04 Dec 2023 02:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Dec 2023 07:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.170167668511443 (code B ref 66394); Mon, 04 Dec 2023 07:59:01 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 4 Dec 2023 07:58:05 +0000 Original-Received: from localhost ([127.0.0.1]:33417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rA3q8-0002yV-JB for submit@debbugs.gnu.org; Mon, 04 Dec 2023 02:58:04 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:51454 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rA3q5-0002y9-If for 66394@debbugs.gnu.org; Mon, 04 Dec 2023 02:58:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1701676670; bh=k/N9Ipap95+ho+wWUpqeOVkVNUwQ7QdxoCLSgO0mlY0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Gfv+gvqaHU2AI9so0nF9k88yDQkaAS0binC6CZnRBhB9VSz3yeOz78ou+/pfxMv7i 8YlKCGgdzEBksUapJ7knqqqlA33k4EOKr5E2Tyb+q95tWMzF9DgvXv1n3Qq2Ps+3nA 4RHEYlvEJwzlMAEm4k6uyVeZJAlNAo7XioKYHNwP2tcc0LF8vXGP94z9d4d4h8OojI T9Y4osIg0cHeVCM7QWHPL9kjTWLrokVELSGNUak+hoJQ+XRCa2lfUPyfaCmogg0RSe NsAG6FI32l+0/2lqooBpP9yGwyMBezcPy15C2lEswUanpmHAPRXMZU0J2cBDQL4ONF SoLnK36ccvZbw== In-Reply-To: <87r0k2pgq6.fsf@posteo.net> (Thierry Volpiatto's message of "Mon, 04 Dec 2023 07:30:25 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275477 Archived-At: Hi Thierry, Thierry Volpiatto writes: > Eshel Yaron writes: > >> The idea is to provide the nice of enhancements from Thierry's patch via >> more minimal changes, > > Your patch fails to provide all the enhancements I had provided. Thanks for testing. Indeed, I only reimplemented the parts I saw as clearly beneficial. Most importantly, my patch improves stuff without breaking other stuff. Perhaps you can explain your use case for the rest of the changes, and if there's a good and compatible way to add them I'll be happy to look into it at some point. > - No filtering. > - No navigation. > - No default registers. > - No possibility to configure a new command added to register. If you could elaborate about these bullets, and explain their use, that'd be great. > - You reintroduced the old implementation which was not wrote correctly > about handling various keys, particularly C-g. How so? Works well over here, AFAICT, as it did in Emacs 29. > - About overwriting, now you have to press "y" to confirm instead of > pressing RET. Yes, I think `y-or-n-p` is more user friendly here, don't you? Cheers, Eshel