From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67702: 30.0.50; insert-register can no longer be used in minibuffer Date: Fri, 08 Dec 2023 08:31:15 +0100 Message-ID: References: <83jzpp19xg.fsf@gnu.org> <87wmtpgooa.fsf@posteo.net> <83bkb117y2.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36136"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Thierry Volpiatto , kun.liu@gmail.com, 67702@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 08 08:32:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBVLJ-0009Be-6e for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Dec 2023 08:32:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBVKx-0002bj-Ju; Fri, 08 Dec 2023 02:31:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBVKw-0002bW-DQ for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 02:31:50 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rBVKw-00089r-5Y for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 02:31:50 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rBVL8-0001XG-Iv for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 02:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Dec 2023 07:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67702 X-GNU-PR-Package: emacs Original-Received: via spool by 67702-submit@debbugs.gnu.org id=B67702.17020206955854 (code B ref 67702); Fri, 08 Dec 2023 07:32:02 +0000 Original-Received: (at 67702) by debbugs.gnu.org; 8 Dec 2023 07:31:35 +0000 Original-Received: from localhost ([127.0.0.1]:43704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBVKh-0001WM-2o for submit@debbugs.gnu.org; Fri, 08 Dec 2023 02:31:35 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:53088 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBVKd-0001W3-SZ for 67702@debbugs.gnu.org; Fri, 08 Dec 2023 02:31:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1702020678; bh=eUrQIP8RFQPO4HhIN/u/btaRp5IKrMdSReBraODbSYk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Pcyf+Kq4GeHOg1/ZRTe+R3Yx/HQdgjeFhshaHUhLwqb0Z6cYs48brCZx9TCFG0FwL IU63/muIlqBFEbyBz+CTkNiJRb1Bk1UH4yv8Rv6OMMqunrXVwNEXnJ7w0CR4VVj4vl 0AFN1RGxGEopjyeOFO/YPmxGNOpAISgl/7sbmq9ehfbT5g1Df0IW8WMa61E5OEtONf dRIErHjlaovo3CUvV4IaLFhinedCOFWcqnNSAQR0ux8SRM/ejlsT/gKVXA6CZESi9D di0aWxDNfFOf6alAy7oc2NaVavX1iPKseFbDAWF5T+D0CAyux+NM3CIhbjMrHpU8Gk p7qQC18H+VVFA== In-Reply-To: <83bkb117y2.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 08 Dec 2023 09:15:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275730 Archived-At: Hi Eli, Eli Zaretskii writes: >> From: Thierry Volpiatto >> Cc: Kun Liu , 67702@debbugs.gnu.org >> Date: Fri, 08 Dec 2023 07:04:53 +0000 >> >> >> 1) Save some text in register a >> >> 2) M-x query-replace >> >> 3) in the minibuffer, type C-x r i >> >> 4) got error: "byte-code: Command attempted to use minibuffer while in minibuffer" Yes, this regression is one of the issues I pointed at with the recent `register-read-with-preview` changes. >> > I guess register-read-with-preview should temporarily bind >> > enable-recursive-minibuffers to a non-nil value? >> >> Yes, do you want me to install this change? > > If you think that's the correct solution, sure. FWIW, I think it's not the right solution. As I wrote in bug#66394, I think it's wrong to involve the minibuffer in reading registers in any way. `enable-recursive-minibuffers` would make this less broken, but only slightly. >> I have also a pending patch to apply for bug#66394 (see it there). > > You said you will install that if no one objects. I'm not sure what > was the conclusion of the discussion with Eshel about that. It's up to you maintainers to decide, I think. Following your request, I've proposed a patch that reverts Thierry's changes, and implements the parts I find useful in a clean and backward compatible way. > If it's unrelated, then please go ahead and install your changes in > that discussion. In any case, perhaps you could help Eshel improve > and polish his additions, which AFAIU are supposed to provide an > optional behavior more similar to the previous one. That'd be nice, thanks. Best, Eshel