From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master a4014c058b5 1/2: Add new `header-line-active' and `header-line-inactive' faces Date: Wed, 04 Dec 2024 10:47:18 +0100 Message-ID: References: <173176622414.2711857.390137952858045982@vcs3.savannah.gnu.org> <20241116141026.7FC37462447@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13908"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Trevor Murphy To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 04 10:48:10 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIlzN-0003Vi-CR for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Dec 2024 10:48:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIlyf-0001Cf-85; Wed, 04 Dec 2024 04:47:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIlyd-0001CB-Di for emacs-devel@gnu.org; Wed, 04 Dec 2024 04:47:23 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIlyb-0003rm-I0 for emacs-devel@gnu.org; Wed, 04 Dec 2024 04:47:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1733305640; bh=8hg0TlXKIZxkCi7A7op2/bOrBnRH9LYQRAOehrcs5/s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ioHyAEo6w/DYk6VSTK52Lg25+Qv0mj0GJIzOMqnvdSqMPLMyYdiPCJ2yijgcklzE9 GjxQFr92FE7nTWEsRz6S9708imhz3iS3jWPQw1MZblnl/OmvnP6icucrMZRkDWWGX4 gzZtrqvwRephrXJliID8r34gDw0Hi3RNFLyPb2fAONjwCS9M6jH58jfDlFwKDiUvEj VV4tQAQCSKzamJUhofVwPu21rsVQ1hbAnLEkUPLq4JClKLu2PErj3I6WQcazvkBFgp GWq0EoHcjNTy+8CKSxBf+FN8MGginH33ErlEo5JFo4Wq+EygMOnDDMd2EwvgFjOZBr KEVp+Er8I+tWg== In-Reply-To: <20241116141026.7FC37462447@vcs3.savannah.gnu.org> (Eli Zaretskii's message of "Sat, 16 Nov 2024 09:10:26 -0500 (EST)") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326020 Archived-At: Hi, Eli Zaretskii writes: > branch: master > commit a4014c058b547d4f9c8c61c6737c85c2636fdb34 > Author: Trevor Murphy > Commit: Eli Zaretskii > > Add new `header-line-active' and `header-line-inactive' faces > > This is all intended to parallel the 'mode-line-active' and > 'mode-line-inactive' distinction. [...] This seems to introduce a regression, consider the following recipe: 1. emacs -Q 2. In the scratch buffer, evaluate: (setq header-line-format "foobar") (face-remap-add-relative 'header-line 'highlight) 3. Type C-x C-M-= or something similar to force updating the header line. The header line in the scratch buffer now shows "foobar" and uses the highlight face, as expected 4. Type C-x 4 b new RET to switch to another buffer in another window 5. In the new buffer evaluate (setq header-line-format "foobar") 6. Observe that the header line in the new buffer is also using the highlight face. That's unexpected! 7. Type C-x C-M-= while the new buffer is current 8. Observe that the header lines in both windows no longer have the highlight face. That's unexpected! Before, remapping the header-line face with face-remap-add-relative would only affect the current buffer, as expected. Now it seems like the face remapping "leaks" between buffers/windows somehow... Best regards, Eshel