From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master ff3f17ca3cd: choose-completion: Retain the suffix after completion boundary Date: Sun, 12 May 2024 14:38:57 +0200 Message-ID: References: <171522198055.22327.4428936546182324178@vcs2.savannah.gnu.org> <20240509023301.A25B3C1F9DE@vcs2.savannah.gnu.org> <7be03e7e-6b8a-420c-b0d8-a512d7917cf2@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27529"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 12 14:39:55 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s68Ud-0006xk-Cm for ged-emacs-devel@m.gmane-mx.org; Sun, 12 May 2024 14:39:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s68To-0005eQ-8V; Sun, 12 May 2024 08:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s68Tm-0005di-Gh for emacs-devel@gnu.org; Sun, 12 May 2024 08:39:02 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s68Tk-0006VY-RV for emacs-devel@gnu.org; Sun, 12 May 2024 08:39:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1715517539; bh=AEYXmPsaP5lYHyUM3KXC/ty/Iol3Ps4l2U67N5J8RdM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=rhCvBlX4MOt8+s7q/MVfBaV2GJXQJPejZVoDFKnAOWOT2a0mtID0EGakSWcjGZ1bN a0laOnjMk1hPCJuX2bwEG0ZFWRc4T6JjaAXmfJstNEzRBizZlowFykstNCcpb+xqFl agA2rgbJYTSmraKldQg4u0JBHBOynNXw8wmAY7PLqx0qKQII4eA3wY9XLSRBWLi6nH KfI/OXEHqPLPyuV927qMXYf75SBeYUA1wxIl9bPCcYOdvMuKSdzznpLXb0Q0Y7KG1l k2sIbbDfOvrAEIX0Up/x0KTCLiCyXWqcIvsf2eNjNE8rGUOlVrLUVBd5nXnDG3JE3c NN/t8NXaKbR6A== In-Reply-To: <7be03e7e-6b8a-420c-b0d8-a512d7917cf2@gutov.dev> (Dmitry Gutov's message of "Sun, 12 May 2024 05:59:49 +0300") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319185 Archived-At: Dmitry Gutov writes: > Hi Eshel, > > On 10/05/2024 19:10, Eshel Yaron wrote: > >>> branch: master >>> commit ff3f17ca3cdd9e82355942f577e7807acc76ddcd >>> Author: Dmitry Gutov >>> Commit: Dmitry Gutov >>> >>> choose-completion: Retain the suffix after completion boundary >>> >>> * lisp/minibuffer.el (completion-base-suffix): >>> Remove as not optimal after all (bug#48356). >>> (completion--replace): Use insert-before-markers-and-inherit. >> [...] >> >>> - (insert-and-inherit newtext) >>> + (insert-before-markers-and-inherit newtext) >> It seems that this change breaks the cycling behavior of >> minibuffer-force-complete. You can see the problem by saying: >> 1. emacs -Q >> 2. (setq completion-cycle-threshold t) >> 3. Open some buffers >> 4. C-x b TAB TAB TAB ... >> The repeated TAB presses are expected to cycle through the >> completion >> candidates (this is the behavior in Emacs 29 for example) but now each >> TAB appends to the minibuffer input instead of replacing it. > > Thanks for reporting that. Indeed cycling was a special case because > it tracks BEG with a marker. > > This should be fixed in commit f0009c2f5ae, hopefully without > regressing on other cases. Great, thanks! I can't seem to find this commit, though, is that on master?