From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#7548: 23.2.90; bookmark-default-handler wrong documentation Date: Sun, 05 Dec 2010 14:14:21 +0000 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1291558539 31172 80.91.229.12 (5 Dec 2010 14:15:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 5 Dec 2010 14:15:39 +0000 (UTC) Cc: Karl Fogel , Thierry Volpiatto To: 7548@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 05 15:15:34 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PPFNF-0007sF-0r for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Dec 2010 15:15:33 +0100 Original-Received: from localhost ([127.0.0.1]:52262 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPFNE-0006fE-Cg for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Dec 2010 09:15:32 -0500 Original-Received: from [140.186.70.92] (port=44208 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPFN6-0006f2-Su for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2010 09:15:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPFN2-0007D3-Ng for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2010 09:15:24 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPFN2-0007Cz-Kg for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2010 09:15:20 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PPFGw-0000G5-7Z; Sun, 05 Dec 2010 09:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2010 14:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7548 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7548-submit@debbugs.gnu.org id=B7548.1291558118924 (code B ref 7548); Sun, 05 Dec 2010 14:09:02 +0000 Original-Received: (at 7548) by debbugs.gnu.org; 5 Dec 2010 14:08:38 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPFGY-0000Er-DD for submit@debbugs.gnu.org; Sun, 05 Dec 2010 09:08:38 -0500 Original-Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPFGX-0000EV-5o for 7548@debbugs.gnu.org; Sun, 05 Dec 2010 09:08:37 -0500 Original-Received: by wyf23 with SMTP id 23so10438185wyf.3 for <7548@debbugs.gnu.org>; Sun, 05 Dec 2010 06:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=EFgze3/7AXrK+JZ++BHmh/ZDX4iCoWPPQN1HAjQk9Jw=; b=cGsFk2ngQORMqvEhaDaghgbqcZ9c7mZqc6tzPDPc8CrMIMoJ3j+Zs2qE//j8G3TE3/ D6uwcSSspgOqikwGdbNOxCl7hGHt5VLlpEE1tbbYEwhvagzB9fBZsMbSf61KbYN200Al BPEknwnMDodeDnjBVkBGckDzQMtuI7Bu6VRqA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=NVRGYui1XNCze04R+KnuOa61ehJs7rTN1PJ1XKJ9f0mcDuilCBWhN2RSGWzELpxFlc UDNdzqt2QT9grWyvJW1p/MWKRk4EjaU1U955ZwZQ1MWvam3tvJrqzXkcjAEuqXMoNSAl eXFNw3ptOS6TIQGy7ivnQdXwZe5biw75yMkWc= Original-Received: by 10.216.13.134 with SMTP id b6mr1577886web.25.1291558466355; Sun, 05 Dec 2010 06:14:26 -0800 (PST) Original-Received: from Victoria.local (cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com [86.9.122.85]) by mx.google.com with ESMTPS id w29sm1856218weq.19.2010.12.05.06.14.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 05 Dec 2010 06:14:25 -0800 (PST) In-Reply-To: (Leo's message of "Sat, 04 Dec 2010 05:45:53 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.90 (Mac OS X 10.6.5) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 05 Dec 2010 09:09:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42175 Archived-At: On 2010-12-04 05:45 +0000, Leo wrote: > As far as I can tell the arg BMK-RECORD to bookmark-default-handler is > not a bookmark record but a BOOKMARK. This is probably leftover. Could > someone correct this? Thanks. > > Leo Posted on Theirry's behalf. ================================ Leo writes: > Hello Thierry, > > I am wondering if you have time to comment on > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7548. Yes indeed, in bookmark-default-handler but also on other places in bookmark.el, the argument "bookmark" is confusing. It refer sometime to a "bookmark-name" and sometimes to a "bookmark-record". That is a vestige of old version of `bookmark-prop-get' that was accepting only "bookmark-record". But now `bookmark-prop-get' accept both, so such comments in docstring are no more needed. Also the arg "bookmark" should be "bookmark-name" or "bookmark-record" instead of "bookmark". All functions bookmark-get-* are calling `bookmark-prop-get'. ,----[ Exemple ] | (bookmark-prop-get '("Any comment on bug #7548 " | (visits . 0) | (time . 1291556487.101218) | (position . 219) | (location . "Gnus-art nnimap+gmail:INBOX:12912:") | (group . "nnimap+gmail:INBOX") | (article . 12912) | (message-id . "") | (handler . gnus-summary-bookmark-jump)) | 'handler) | ==>gnus-summary-bookmark-jump | | (bookmark-prop-get "Any comment on bug #7548 " 'handler) | ==>gnus-summary-bookmark-jump `---- Maybe you can forward this to emacs-bug? > Thanks. > > Leo -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 ================================