From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 3/3] octave.el: Go to error in inferior-octave. Date: Fri, 04 Oct 2013 18:04:36 +0800 Message-ID: References: <1542085.GCVjMo2CM9@descartes> <97BF0F35-1CB8-411A-9B47-803CF33130CF@gmail.com> <2832315.j8Ubslmhy0@descartes> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1380881101 21528 80.91.229.3 (4 Oct 2013 10:05:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Oct 2013 10:05:01 +0000 (UTC) Cc: Stefan Monnier , "emacs-devel@gnu.org" To: =?iso-8859-1?Q?R=FCdiger?= Sonderfeld Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 04 12:05:05 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VS2Fs-00050e-U9 for ged-emacs-devel@m.gmane.org; Fri, 04 Oct 2013 12:05:05 +0200 Original-Received: from localhost ([::1]:47103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS2Fs-0004bc-HF for ged-emacs-devel@m.gmane.org; Fri, 04 Oct 2013 06:05:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS2Fh-0004YZ-Hb for emacs-devel@gnu.org; Fri, 04 Oct 2013 06:05:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VS2FZ-0000z3-3s for emacs-devel@gnu.org; Fri, 04 Oct 2013 06:04:53 -0400 Original-Received: from mail-pb0-x22b.google.com ([2607:f8b0:400e:c01::22b]:41986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS2FY-0000yw-T3 for emacs-devel@gnu.org; Fri, 04 Oct 2013 06:04:45 -0400 Original-Received: by mail-pb0-f43.google.com with SMTP id md4so3763763pbc.2 for ; Fri, 04 Oct 2013 03:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=cQpJlzUpYaNS77An+UHVvSorfZuZ5f+fFDwAINQdQcI=; b=r4EjRY6oiA16HbUDEvh3sBhojwnlReKo3pxhftT6zi2TMbiYwQRBvYX4RP8TGHRLEl D6ZRykNYOYlk2dmk8FZ3Yx4LPW/rmExHxeejmGKVIrJ9eVojj5aG8Wl7c7I8KKXEO+hK rhJlImKDABP4v+1H0TeySeF5zqPXOev/wHA7k6TKYIQDbgMwU3wf90o9AFnF/gHWdPs7 fNVjbUujT6N0GhonQptyLp408i0VYU+6CnfcelALwHCSAEzCA3u7hfo3qAsMxf0+4uyb mXCGDV889ecp/HdK54aC1Z5JvQ34OpwZVtOgHAdgVfRZ3hPkfWvkJjnnO5PcYg7g/SF7 51/w== X-Received: by 10.68.33.100 with SMTP id q4mr5474111pbi.119.1380881083832; Fri, 04 Oct 2013 03:04:43 -0700 (PDT) Original-Received: from localhost ([123.115.243.110]) by mx.google.com with ESMTPSA id xe9sm16951865pab.0.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 04 Oct 2013 03:04:43 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC In-Reply-To: <2832315.j8Ubslmhy0@descartes> (=?iso-8859-1?Q?=22R=FCdiger?= Sonderfeld"'s message of "Thu, 03 Oct 2013 15:39:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.5) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c01::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163843 Archived-At: I have committed the patch to use `compilation-shell-minor-mode' please give it a try. Thanks. On 2013-10-03 21:39 +0800, R=FCdiger Sonderfeld wrote: > Oh, I was looking for something like `compilation-shell-minor-mode' yeste= rday=20 > but must have missed it. This should probably make patches 1 and 3 obsol= ete.=20=20 > But I think patch 2 is still valid. Comint is already having highlight f= or=20 > the prompt and adding our own highlight in octave.el is not necessary and= just=20 > confusing. The small prompt font-lock by inferior-octave shouldn't be a problem because it will have effect only on prompts of past inputs. BTW, seems stop working that way in trunk. Leo