all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Liu <sdl.web@gmail.com>
To: John Wiegley <jwiegley@gmail.com>
Cc: Mark Oteiza <mvoteiza@udel.edu>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 5811404: Replace eldoc-documentation-function with a hook
Date: Thu, 14 Jul 2016 21:36:23 +0800	[thread overview]
Message-ID: <m1mvlke3zc.fsf@gmail.com> (raw)
In-Reply-To: <jwvpoqmgx14.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Sat, 09 Jul 2016 20:27:52 -0400")

On 2016-07-09 20:27 -0400, Stefan Monnier wrote:
> A *-function variable is not an advice, but a hook.
>
> It's a different kind of hook than those manipulated by add-hook (which
> have names ending in -hook or -functions), but it's still a hook and
> those have been used for many years in various parts of Emacs.
>
> It just so happens that the operations that can manipulate those hooks
> conveniently (add-function/remove-function) are provided in the same
> file as the new advice-add, but that's only because it was convenient
> and natural to implement advice-add on top of those new operations.

May we have this incompatible change reverted?

Thanks,
Leo



  reply	other threads:[~2016-07-14 13:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160707032857.31916.95107@vcs.savannah.gnu.org>
     [not found] ` <20160707032857.E4A1422015C@vcs.savannah.gnu.org>
2016-07-07  9:36   ` [Emacs-diffs] master 5811404: Replace eldoc-documentation-function with a hook Stefan Monnier
2016-07-07 19:31     ` John Wiegley
2016-07-07 23:59       ` Mark Oteiza
2016-07-08  0:06         ` Dmitry Gutov
2016-07-10  0:27         ` Stefan Monnier
2016-07-14 13:36           ` Leo Liu [this message]
2016-07-15  0:16             ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1mvlke3zc.fsf@gmail.com \
    --to=sdl.web@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=jwiegley@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=mvoteiza@udel.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.