all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Sam Steingold <sds@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: master 5aa6a15: Treat the "Link" link in gnus-summary-browse-urls specially
Date: Wed, 24 Jul 2019 12:01:42 -0400	[thread overview]
Message-ID: <m1muh3h15l.fsf@gnu.org> (raw)
In-Reply-To: 87o91jzj7t.fsf@mouse.gnus.org

> * Lars Ingebrigtsen <ynefv@tahf.bet> [2019-07-24 14:54:14 +0200]:
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Could we put this back the way it was? I don't know why "Link" as link
>> text should be treated specially -- now if any of the urls are called
>> "Link" I have to delete the text. At least make it the default argument
>> to `completing-read', not the inital input. But I don't see why this
>> text is treated specially.
>
> As a DWIM thing, it may make sense?  But, yes, it shouldn't be the
> initial input.  As a default it's nice, though.  But then perhaps it
> should say (in the prompt) what the default is, which will make the
> default very long...

Precisely why I chose to use it as the initial input instead - because
if you do not like it, "C-a C-k" is fast enough.

> Other usability nits in that function: It uses widget-move, which will
> echo the contents, which is very annoying, because that means that it
> flashes a large number of things in the echo area.

That I will fix, thanks.

> And the prefix argument to `w' should probably be to act the same as in
> eww; i.e., use `shr-external-browser' for the browser.

Alas, the prefix argument is already used there ("also collect links
from message headers"), and it was so before my change, I will leave it
to you to change (personally, I never use eww).

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1671
http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com
http://iris.org.il http://honestreporting.com http://islamexposedonline.com
Linux: Telling Microsoft where to go since 1991.




  reply	other threads:[~2019-07-24 16:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190716212507.31541.72823@vcs0.savannah.gnu.org>
     [not found] ` <20190716212509.24A6E20BE2@vcs0.savannah.gnu.org>
2019-07-24  3:14   ` master 5aa6a15: Treat the "Link" link in gnus-summary-browse-urls specially Eric Abrahamsen
2019-07-24 12:54     ` Lars Ingebrigtsen
2019-07-24 16:01       ` Sam Steingold [this message]
2019-07-24 15:56     ` Sam Steingold
2019-07-24 17:13       ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1muh3h15l.fsf@gnu.org \
    --to=sds@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.