From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Daniel_Mart=C3=ADn?= Newsgroups: gmane.emacs.devel Subject: Re: Yet another global/gtags package into elpa.. Date: Sat, 02 Apr 2022 02:47:44 +0200 Message-ID: References: <20220328232754.feeavepjtqauvnv5.ref@Ergus> <20220328232754.feeavepjtqauvnv5@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10556"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (darwin) Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 02 02:49:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1naRx9-0002XP-EH for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Apr 2022 02:49:21 +0200 Original-Received: from localhost ([::1]:55508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naRx8-0002zj-7e for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Apr 2022 20:49:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naRvp-0002F1-Fj for emacs-devel@gnu.org; Fri, 01 Apr 2022 20:47:57 -0400 Original-Received: from sonic313-21.consmr.mail.ir2.yahoo.com ([77.238.179.188]:33288) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naRvm-0004Yc-Tr for emacs-devel@gnu.org; Fri, 01 Apr 2022 20:47:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1648860470; bh=uK9i5zMWBC1xmgR5eadyp+VUXFtbCtxChNAQ5YsIUto=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=MbIvMLgJbWhA0Z0J8vOYt2jyB8uzZPbbk0LB/jzAkcCbMe2zM/6a59JZCGZwW2L2bKKVoMItrSB2iK0lNdeYyQFC179g+AGD6BoJYKjDS9DPKEElRGpXIUVF5UBaZ70Z9EHrZ3N8zBfM4yJ62s+8gjUCPqFbalU/YXSnZ7TRZy6HX1zxGuD5dPyXWDDZ22zDhnWgFdgekN7Uk3y1cRT/vEc9rZmysoez7iAGco2/8PDFjuuL83Mpyi45AQ9S0CQK59v6S/08Zu1UZUjynxQcr0Fkj7aqIAXh+GV3QwI+9BihhqigQYGuQ7Vrb1Y8QlwnAB2MLqMEEvNwo6bCRiBLdA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1648860470; bh=sZttayk0AETKh8rSmyG2ybaqGQqlnaKO8g/4vSbKXX3=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=gOEHJc/GoBKyMrbc9KHSfy1A4/jfTPMgFaplhPzsvdIVJ5a0ZH8aczqKv8iPxMhGxFXDx5bhQGRpRCkS/rro5F87DssRMzUqCwBoNhOK7udLDAfNFWUNwNb6M9rlqAnGNJ9v3Q1Ie4Ha/ByFrdvIGAT914knp6pWj2L9cWBlaOgQrSrSOOPDnmo9D2tVJ/6kLdxwCFS8MqotvzUV1GL7g+7mklYxwYcqzPciuZpEQZgQOYyIxzTKNU5bftDBiIFRPWpxDzmmPgHpVYTFP9ox4tJnNbuDoV1ZZmNv00o2r57BhkOJ9SE8Tvnray/trY7uOwtc/TnAtHovJoMkDkF3kw== X-YMail-OSG: N9L389kVM1mq2mAQ9f0mA64nY.tBBS1Ll3xkOm8owBqWPeddB66hYdhgBSLrVHJ 39ZdU7FbuDEGwztWrdsvxEZlbRqiTqKWycPHrKICevPcduUIpJLEUREofx4FdfRiUPCFmbIVzcXA IBHIM2B_rMze_mPili1JaFBs0Jtyr5K.L7h9zqBrv8SlV.zuTbSajJf6k3qeMvDo59tPR3J9I3Do iXxAS1dSloqgOGGumD4fV7BHD2l5wLXUl8S6qH0oWdUXyiCqumJOohSO.UY6eubkyykSBhBjk.Oy 5IPa9ukDr_gCKfxb_o4djAGSoREx9o5WRfOhmGzx9ovtqJ6KZfjTmaGyN3xXn4raonaqygInSqk3 92U1ytgVjzvKEpT2oDY8AtFRZ1rQvH7l2SFgy48Ca_noyc.QonqwtScXzp9StLJ9WPPbnwaGxUvN vpK5sss43utixStzSx4Bkj3KOugEuWQ50KlfFaxbd.DNOXbHryVP1yYymd8f36ySj7euVPBRXBIr l.EBCmkI9o5aBb4aNQiE4kvj43g1RGKfvnnAPrZx5HxNeNLQiCc.bV2NkzJ7MIgCrB0X0pWAIwjl mEodL9HfYFt3bWRXUlC.aiKveqAGgkEDZHWNjjbq.uMhyAx9k2WXWCxzshpJxrYYhsMzW6rLJPb9 vYABC7lRN3Q6DTa4p8fZsNo7.qT6SlQSIwglygBScotoFjlTJS0cQWs_RFTccNHAEvU.2Tbcp7cS ybjDUiZA427cJJYY69a08JeVobuvYtNCR2DnRe.ZbPHBf7Oyqb1s9RRrx8SmFCk1xoq1lwy_VmIk eltdW4QnORRLOuaKGFngqdS08dCKSFCNYedMh.qzrB X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Sat, 2 Apr 2022 00:47:50 +0000 Original-Received: by kubenode509.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID b4d68d1a20f39f963c8165764968a60e; Sat, 02 Apr 2022 00:47:44 +0000 (UTC) In-Reply-To: <20220328232754.feeavepjtqauvnv5@Ergus> (Ergus's message of "Tue, 29 Mar 2022 01:27:54 +0200") X-Mailer: WebService/1.1.20001 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=77.238.179.188; envelope-from=mardani29@yahoo.es; helo=sonic313-21.consmr.mail.ir2.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287689 Archived-At: Ergus writes: > Hi: > > After many years dealing with issues (specially with tramp) with all the > global/gtags packages around (agtags, gxref, counsel-gtags, ggtags and > global-tags) I definitively implemented my own simpler one only with > emacs internal infrastructure, and I am wondering if it may be fine to > add it to elpa. The package could be even added to vanilla due to it's > simplicity and because fully integrates into the emacs ecosystem. > Thanks, I think it's a good idea that Emacs has first class support for GNU Global. I have some suggestions for your package: ;; Package-Requires: ((emacs "28")) Is there a reason the package requires such a recent version of Emacs? If it's only because you use string-lines, that logic can be implemented in terms of split-string, which is available since Emacs 20.1, at least. ;;; Commentary: ;; GNU Global integration with xref, project and imenu. It'd be nice to add a ;;; Usage section that describes how to make the package work. You can reuse some of the information you have in the Readme.md file. For example, you should advertise the gtags-mode-create command, which generates the tags files for the project. (defcustom gtags-mode-lighter "Gtags" "Gtags executable." :type 'string :risky t) To make things look good in the modeline it's better to add a space before the lighter, so it should be " Gtags". Also, the docstring seems incorrect. (add-hook 'after-save-hook #'gtags-mode--after-save-hook nil t) Could this be optional/configurable? I think some people would prefer to update the GTAGS database manually via a command and not each time the file is saved. (when (called-interactively-p 'all) (message "Couldn't enable gtags-mode. Not root found.")) ^^^^^^^ Should be (error ... This error message is also a bit confusing. I think it should say something like "No tags file found" or similar. Thanks.