bug#68018: [PATCH] Fix previous page and next page tooltips in doc-view.el

["Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Po Lu <luangruo@yahoo.com> writes:

> Daniel Martín <mardani29@yahoo.es> writes:
>
>> In docview.el, the toolbar icons used to navigate to the previous and
>> next pages have incorrect tooltips.  I've attached a patch to address
>> this issue.  Thanks.
>
> Thanks, but why rename the icon?

So that the name of the icon matches what the icon really represents.
If you feel that renaming the icon may cause incompatibilities, here’s a
new patch that only changes the help tooltip.  Thanks.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-previous-page-and-next-page-tooltips-in-doc-view.patch --]
[-- Type: text/x-patch, Size: 1503 bytes --]

From bd5e5f563d7388ba71eb5496766bc1d5a5fdeb23 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= <dmartin@Daniels-MacBook-Pro.local>
Date: Mon, 25 Dec 2023 11:43:39 +0100
Subject: [PATCH] Fix previous page and next page tooltips in doc-view.el

* lisp/doc-view.el (doc-view-tool-bar-map): Fix toolbar items to go to
next and previous pages in a document.
---
 lisp/doc-view.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index 2fdb49f3e42..c70b60d9f58 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -698,12 +698,12 @@ doc-view-tool-bar-map
     (tool-bar-local-item-from-menu 'doc-view-previous-page "last-page"
                                    map doc-view-mode-map :vert-only t
                                    :enable '(> (doc-view-current-page) 1)
-                                   :help "Move to the next page.")
+                                   :help "Move to the previous page.")
     (tool-bar-local-item-from-menu 'doc-view-next-page "next-page"
                                    map doc-view-mode-map :vert-only t
                                    :enable '(< (doc-view-current-page)
                                                (doc-view-last-page-number))
-                                   :help "Move to the last page.")
+                                   :help "Move to the next page.")
     map)
   "Like the default `tool-bar-map', but with additions for DocView.")
 
-- 
2.42.0