From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 68671@debbugs.gnu.org
Subject: bug#68671: 30.0.50; C-x 8 e s RET persistently breaks C-x 8 e r
Date: Sat, 27 Jan 2024 14:10:15 +0100 [thread overview]
Message-ID: <m1mssqc47c.fsf@dazzs-mbp.home> (raw)
In-Reply-To: <86cytn820u.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Jan 2024 13:10:57 +0200")
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
Hi,
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Tue, 23 Jan 2024 11:59:41 +0100
>> From: Eshel Yaron via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>>
>> 1. emacs -Q
>> 2. C-x 8 e s RET
>> [ i.e. invoke `emoji-search` and exit with an empty minibuffer ]
>> 3. Observe error "Wrong type argument: char-or-string-p, nil". This
>> error message could be more friendly, but that's not the issue here.
>> 4. C-x 8 e r
>> 5. Observe error "Wrong type argument: stringp, nil". That's the issue.
>>
>> What happens is that C-x 8 e s RET adds `nil` to the value of
>> `emoji--recent`, which breaks subsequent C-x 8 e r (`emoji-recent`).
>> This is extra troublesome because `emoji--recent` is used as a
>> multisession variable, so simply restarting Emacs doesn't help.
>>
>> I see this also with Emacs 29.2, FWIW.
>
> Thanks. Patches for fixing this will be most welcome.
I'm attaching such a patch below. This provides better feedback when
you exit the `C-x 8 e s` minibuffer with an empty input, and avoids
adding `nil` to `emoji--recent` by bailing beforehand.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-emoji-read-emoji-Signal-error-on-empty-input-Bug-686.patch --]
[-- Type: text/x-patch, Size: 1288 bytes --]
From 121c0d8ef1a4cde8cc3538870e165f963227d074 Mon Sep 17 00:00:00 2001
From: Eshel Yaron <me@eshelyaron.com>
Date: Sat, 27 Jan 2024 14:01:47 +0100
Subject: [PATCH] ; (emoji--read-emoji): Signal error on empty input
(Bug#68671)
---
lisp/international/emoji.el | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/lisp/international/emoji.el b/lisp/international/emoji.el
index 3b97d6915af..cab1d2e663c 100644
--- a/lisp/international/emoji.el
+++ b/lisp/international/emoji.el
@@ -680,11 +680,12 @@ emoji--read-emoji
"")))
strings)))))
nil t)))
- (when (cl-plusp (length name))
- (let ((glyph (if emoji-alternate-names
- (cadr (split-string name "\t"))
- (gethash name emoji--all-bases))))
- (cons glyph (gethash glyph emoji--derived))))))
+ (if (cl-plusp (length name))
+ (let ((glyph (if emoji-alternate-names
+ (cadr (split-string name "\t"))
+ (gethash name emoji--all-bases))))
+ (cons glyph (gethash glyph emoji--derived)))
+ (user-error "You didn't specify an emoji"))))
(defvar-keymap emoji-zoom-map
"+" #'emoji-zoom-increase
--
2.42.0
next prev parent reply other threads:[~2024-01-27 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 10:59 bug#68671: 30.0.50; C-x 8 e s RET persistently breaks C-x 8 e r Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-27 11:10 ` Eli Zaretskii
2024-01-27 13:10 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-01-27 13:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1mssqc47c.fsf@dazzs-mbp.home \
--to=bug-gnu-emacs@gnu.org \
--cc=68671@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.