From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 b6d6304: Comment on last change to define-derived-mode Date: Sat, 05 Mar 2016 17:48:05 +0800 Message-ID: References: <20160301035146.26012.60163@vcs.savannah.gnu.org> <0ff1a53d-bbdf-7393-5462-516c89a582d8@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457171333 3349 80.91.229.3 (5 Mar 2016 09:48:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Mar 2016 09:48:53 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 05 10:48:43 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ac8pG-0007IM-Ej for ged-emacs-devel@m.gmane.org; Sat, 05 Mar 2016 10:48:42 +0100 Original-Received: from localhost ([::1]:45430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ac8pF-0000NU-Rh for ged-emacs-devel@m.gmane.org; Sat, 05 Mar 2016 04:48:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ac8p2-0000NJ-LK for emacs-devel@gnu.org; Sat, 05 Mar 2016 04:48:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ac8ox-00017f-LS for emacs-devel@gnu.org; Sat, 05 Mar 2016 04:48:28 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:38782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ac8ox-00017b-Ee for emacs-devel@gnu.org; Sat, 05 Mar 2016 04:48:23 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ac8ov-000777-4a for emacs-devel@gnu.org; Sat, 05 Mar 2016 10:48:21 +0100 Original-Received: from 221.222.150.241 ([221.222.150.241]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 05 Mar 2016 10:48:21 +0100 Original-Received: from sdl.web by 221.222.150.241 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 05 Mar 2016 10:48:21 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 14 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 221.222.150.241 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (OS X 10.11.3) Cancel-Lock: sha1:1EBUaL3sGiO4XX3W/ehPF7+PQvM= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200938 Archived-At: On 2016-03-05 05:11 +0200, Dmitry Gutov wrote: > That putting the keyword arguments from BODY on the same line as the > mode name is semantically wrong? And it's prone to result in longer > lines? And that right now there's a weird comment inside > define-derived-mode that makes little sense without additional > context? I wouldn't consider the keywords part of BODY (they aren't eval'd as they appear anyway). They actually affect how code is generated. The BODY has at most 3 semantic parts: DOC, KEYWORDS and BODY2. The first 2 are optional. My style is not bizarre and to my eye make the code clear. Everyone has own lisp style and we should do our best to respect them. Leo