From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49731: 28.0.50; Filter xref results by filename Date: Sat, 31 Jul 2021 18:45:35 +0200 Message-ID: References: <030dbe6c-130d-e578-f50d-54e90bfa7cfa@yandex.ru> <7593e0f3-9399-ccf3-21de-b2ac79ae3730@yandex.ru> Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="957"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (darwin) Cc: 49731@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 31 18:46:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9s80-000AbL-MW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Jul 2021 18:46:25 +0200 Original-Received: from localhost ([::1]:60404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9s7y-0007Wf-PS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Jul 2021 12:46:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9s7e-0007WO-Kd for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 12:46:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51423) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m9s7e-0006Na-0Y for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 12:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m9s7d-00048O-V6 for bug-gnu-emacs@gnu.org; Sat, 31 Jul 2021 12:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Jul 2021 16:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49731 X-GNU-PR-Package: emacs Original-Received: via spool by 49731-submit@debbugs.gnu.org id=B49731.162774995115216 (code B ref 49731); Sat, 31 Jul 2021 16:46:01 +0000 Original-Received: (at 49731) by debbugs.gnu.org; 31 Jul 2021 16:45:51 +0000 Original-Received: from localhost ([127.0.0.1]:34736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9s7S-0003wz-IW for submit@debbugs.gnu.org; Sat, 31 Jul 2021 12:45:50 -0400 Original-Received: from sonic307-54.consmr.mail.ir2.yahoo.com ([87.248.110.31]:44655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9s7P-0003om-Qq for 49731@debbugs.gnu.org; Sat, 31 Jul 2021 12:45:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1627749940; bh=xwlSvfzvThaiIgKt69hI2tQoqknFN0g8pU007MZWMHw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=N237mYZftgAp1hlZnGq+HeR+EEz95REWdFTX2ukT8esUPJDaO1I+cOBEab4MOJmyW35oMz2fsVtC3PMvquk/exGU6N8KBlnpIntT4InaFzv5WHnVwgz4FmDVKKFE5hkqo+ctD2iUalcO1/cUCyHzN49Fz3znv3uPBScFMgEkQga3OcWNWpJT/iYzFxXUGjWMD9XFxaCbLYRblme5MyOCRmEFP3cm9zBhlprw+L9FijSASrtipf8gTwAZGAUg7W9Ojv3HhONm3DBzLv9qKiaSp0Imyf3fSpsjpms5Af+rWjLH2KfTrMH96IW7UmcFPXRCVvL+3LTPzoQOZuqBndGM9A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1627749940; bh=LihpV4A8ldy0EsKH4CgwPv/J1ylBvdi2Fga5bdtuc96=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=nWcEsz1YknLa0IziuJURzGZploKIHiwgdI/+42wIg2sisS79lGJusOppMNij4qsugMj9GtmGLnDOUHDkz+uHJqtOY/G/GE68CSfTvez+uQK7xNgXSeehCbF65PeQvJng4hQuae7ziicMEcmprlRYbdDfNGsHwL5g3zRSg1hIVkkFuGwUUvROVmh/d/HYDix3LJohDF/CgYVgGVt70oezkgl+r0Pj+8tqyA2J4yF2PT4tFWDGk+qpCBpeB81Cyo7YhBCRrc2i8l71dfYxjq74HOg1kLEVkWZH1mkcKxG2R4Yw+xBvhZpAs9rgWUik4reMOj2L1UthO6wGP4cf8o/VaA== X-YMail-OSG: 7YKb2xQVM1mEmGYYkLfFEGNPh.Li8FWuGBKI7LQMoj_Viuwc.z15Rgj8Hwp3KAT GhBIk1jrPf28ENqnZNFFCap5hNhsgt6j7h.jWy7fbQbg.fIV08Fh0kO9RonufMmfD01Hjxck5SfG D_I6quMek3BUe8.qTHfQNGudLqO0iuo4uBHUn7Ud3M3R90KUfKrEwR9aXzBZo.c6EhXWeVKHzmu8 YyLfE.PEFPzkDIJ_pXZr4hOEWX4jf54T2xebLu6e1Qu_Ydg7lEuezRlNPbF7A_YTS5LsVTNmd9P6 ZxubioUB1jrB.DSM4_ranPaUD6DWEFBzbZ2uJqLWiWhMszZLcGC19mBm1NahiPwu6wQ57WOvWPV8 W8YPk9okoSeAtzO6eM9w9nppyTEjot2jfs8Bhsa4nTeh2yVQdJQR6boEuOMYZ8w3V8KNQSb1Uf0I HYLaLAvh49LCg9LnngnfXx0lNsAjgySrPUEcRv_qXjD.YIWT3EcT8a6nFMAWmtug1cpbMxJESSEw T5xBqS0xJtk3OfgYneVpriJ6Va1mKx_JSAAapWBeeWFrPmah7NnX1VfjY_16HCyJWVtidUTmHpWH vRjHvl0_o0dvHsKPn4FC0OFP4vGVjsgU67wAnWPPL17CzBWu_fMV7OQFteQj_4_8HPuoME7vtOMa bgjOxbxbue92AyQExze82lb_slb2_4h.tnkUVK6EXGfswlTMpibVfkAJVuvQRLC4XCHMES86tP7b YfUHIxvdN35I2NaxjBuBtxuGccwG2nzqDeHtgcTuRpzCeVKFnRqy7uOMLj4gsjuqEr2YJAoP4C7i SgW1za73n.bgAFJwnI1RIi0MHWmgd9bd3eHj1sPOx. X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Sat, 31 Jul 2021 16:45:40 +0000 Original-Received: by kubenode528.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 38438754952a5277adcc096528ab5bc6; Sat, 31 Jul 2021 16:45:36 +0000 (UTC) In-Reply-To: <7593e0f3-9399-ccf3-21de-b2ac79ae3730@yandex.ru> (Dmitry Gutov's message of "Wed, 28 Jul 2021 03:08:27 +0300") X-Mailer: WebService/1.1.18749 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211006 Archived-At: Dmitry Gutov writes: > > But do we want it to be implemented using outline-mode? Because we > want the corresponding visuals? Because otherwise a dedicated > implementation shouldn't take much more code either (probably roughly > the size of xref-truncation-width feature we added recently). > Yes, I think implementing the feature using outline-mode is not a good idea. It'll load a library that is not small, and more importantly, it is confusing from a UI point of view: It's strange that the xref output, which is initally non-foldable, becomes foldable when you want to filter the output (one may think that why the output can't just be foldable by default). I'd like to take a spin at option 1). How do you think the filtering should happen? At the xref backend level, or at the xref frontend level? I think the filtering can happen in the frontend, provided that the backend provides the necessary information (file path, and symbol type, if we offer to filter by symbol type). Is there any thread where this feature was discussed? Thanks.