From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60623: 30.0.50; Add forward-sentence with tree sitter support Date: Sat, 07 Jan 2023 16:41:57 +0100 Message-ID: References: <87o7ratva2.fsf@thornhill.no> Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37300"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) Cc: theo@thornhill.no, casouri@gmail.com, monnier@iro.umontreal.ca, eliz@gnu.org To: 60623@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 07 16:43:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEBLz-0009V1-Ec for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Jan 2023 16:43:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEBLc-0000B8-Q2; Sat, 07 Jan 2023 10:43:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEBLb-0000Al-JU for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 10:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEBLa-0001qq-W0 for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 10:43:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEBLa-0005vh-FH for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 10:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2023 15:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60623 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: 60623@debbugs.gnu.org, Theodor Thornhill , casouri@gmail.com, monnier@iro.umontreal.ca, eliz@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167310612922723 (code B ref -1); Sat, 07 Jan 2023 15:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Jan 2023 15:42:09 +0000 Original-Received: from localhost ([127.0.0.1]:58747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEBKi-0005uQ-UC for submit@debbugs.gnu.org; Sat, 07 Jan 2023 10:42:09 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:53488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEBKg-0005uD-Uk for submit@debbugs.gnu.org; Sat, 07 Jan 2023 10:42:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEBKg-0007P8-PM for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 10:42:06 -0500 Original-Received: from sonic307-54.consmr.mail.ir2.yahoo.com ([87.248.110.31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEBKe-0001jE-Of for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 10:42:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1673106120; bh=hjmbE2lgd2cKDHYbBB0NSVvR/XeLFHmpFJR66k3HQRk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=TILFen8n4fKvaFhzHbGWEx2vTn3INJ6pgy79yvS8Bde8RxVtyMKHVc9HEp7l0jSQpHGsojqmXYvm+PaKd8gjqRD4z7LRb2SHlyIOD+sVYNq8f8C5YnjjkKGHGAmLoZpkqC09oFYs2ExpbHITYSJEw67bwh0F5DV0D9KNcrhJnVfK3Xp+grbG8mI40kquCJNWb/OWry6Df5FkKx7DR7x/DYXHHpEcT6mFY4ZGMfLmRH0eWZxGkbpOZ8aK+vZwgh+5SqsgNemikAGUwyaeRulA6mDlmDlHMog13f2GucmNyU9K12w5v9epMQsh0dyvSfc+N75Ilvd8ssCaZiUQWN81RQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673106120; bh=pZcr917oWfU6ViT5npNosKxLDpgWL/o9Mv7qCxhQs8V=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=SX027hEyh9Mp+TVBvgBAbs7bfJ6IwHgMoIHcM/nzgRlG0cAx1iamBUfTAbo/KeHlPjhpgxzciWTgliAA38QXl61FE/MRSHMUh3H1ioxbzjS97zINI3OfC789Qr3ciUavimPO7rdBjObtYt5cvoYtIrbPbBzleOx/bhmfK+/ELGetmK7+a0lEH80EWi4Pgy4LlIXN9N2zIWf+NeUFe0Kd6w3f0fhis0L9puDwtpiiuoshCOmTemktf4yYy2OdvM6JcXLSlRUiyUGKwY3YJvAeO4LxryoIj5TsksuwQZHPsk3zWIsPRg1s4GnHtam/6y5ILdPT2eiUfEByxLLBFl2dgg== X-YMail-OSG: k0mLNWUVM1mDtIEu3Bi3qXqrIKvddManfFLQ5a.596smbCMNx7M642XlP0OH6Pn 1BVFwqM.BEZEU0VvVOCPb.zQznxaKvwdx3xeO0s4nHSIqOdlQ4WgLqdYhepIE6uzJE4LRZnkYiZo qYeIn9KjdsAVGDrnU1H2VqCdGV6vb8q_QjClmw2m2pD9tybNXMTAeO9ncJxzbtn1y.JS0W10y8jW XWCd3haRGCR3eMJaAzgynyrcxj_wHMlIP78qF_LQWje10fnl2Z_DyIShPRZftURTalzObza343yw cK9ZhyaPDz7YDcbwnMsmmrmkZQ5VB23oHkZXI4ocZh2wA6t9ZQD.hrpClBXJnskMrjE5tCIpu0S. vrYLe9grC2qe4oKEBWqWsOLbGeQ8RgbWqEMndr.O3hmts0dM1DSHGOPjnQCo46RgcYKsycwF5IDh _tyvWVg_jyJXySpip9ghX4W08Uwn1XaIopiGwNdPYLm8txYMWmGPPKpBRe8O4Fm0YqFeH3LA3DSU GCV0ihCfiSE21YWQvMQt5vKvSWxX86UmCDGgK40Rm3f8LTLsfmThigqWN4BGZqfnv0iXjAcxdslG TgWkANcaa5EX2bVwgtr0qfYHCt56TeDzt_rjCMcy9.HwbvojbKsnRwFz7RY5A7mEPd4Mh.r3.adh jVshkOzsA2AnqyNhBe1j7LXBs1I56jYLtmxnqO2Wz_FcBfcudO5Dxo5sGTRw9Z82Ccw80g5kOIfy qvRTIIXrmFh43EMQ5CUzho_xHUMMQoQAvnsIDXFdmLFnGGh2kXejF8h8tfn_n6PixvBJEhBePnVd XZnpRxOHPKM0vdldD17CM5vEnzSCCQ7fgYVfENedOP X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Sat, 7 Jan 2023 15:42:00 +0000 Original-Received: by hermes--production-ir2-5795fc58c8-hmjd6 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ec1c991b6cc5c08758bd843eaad2fa3a; Sat, 07 Jan 2023 15:41:58 +0000 (UTC) In-Reply-To: <87o7ratva2.fsf@thornhill.no> (Theodor Thornhill via's message of "Sat, 07 Jan 2023 12:54:13 +0100") X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=87.248.110.31; envelope-from=mardani29@yahoo.es; helo=sonic307-54.consmr.mail.ir2.yahoo.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252813 Archived-At: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Hi all! > > This patch tweaks the forward-sentence function to be usable with > tree-sitter. > > It follows the same style as the recent change in transpose-sexps, so I > hope it isn't too controversial. Thanks. > > What exact node types do you consider useful for sentence movement? > I haven't thought much about your proposed nodes, I initially thought that sentences in a programming language are just "statements". As a suggestion, treesit-forward-sentence could navigate by textual sentences when point is inside comments or strings. > +** New defvar-local forward-sentence-function. > +The previous implementation of 'forward-sentence' is moved into this > +variable, which can be set to customize the sentece movement behavior. ^^^^^^^ sentence Also, this feature probably needs an update to the Info documentation to mention that Tree-sitter can specialize sentence commands in programming modes.