From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> Newsgroups: gmane.emacs.bugs Subject: bug#67275: [PATCH] ; Improve and add tests for Completion Preview mode Date: Sat, 25 Nov 2023 12:15:43 +0100 Message-ID: <m1jzq6rsm8.fsf@dazzs-mbp.home> References: <m1sf529gzw.fsf@dazzs-mbp.home> <8334x2ko1y.fsf@gnu.org> <m1jzqe9ecb.fsf@dazzs-mbp.home> <m1r0kkwqyi.fsf@sp-byods-145-109-20-84.wireless.uva.nl> <83r0kecfa6.fsf@gnu.org> Reply-To: Eshel Yaron <me@eshelyaron.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11323"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67275@debbugs.gnu.org To: Eli Zaretskii <eliz@gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 12:16:10 2023 Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org> Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>) id 1r6qdu-0002iV-6K for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 12:16:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <bug-gnu-emacs-bounces@gnu.org>) id 1r6qdk-00028K-Sh; Sat, 25 Nov 2023 06:16:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r6qdh-00026G-SL for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 06:15:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r6qdh-0000yn-K0 for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 06:15:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r6qdm-00019k-Gh for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 06:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron <me@eshelyaron.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 11:16:02 +0000 Resent-Message-ID: <handler.67275.B67275.17009109573794@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67275-submit@debbugs.gnu.org id=B67275.17009109573794 (code B ref 67275); Sat, 25 Nov 2023 11:16:02 +0000 Original-Received: (at 67275) by debbugs.gnu.org; 25 Nov 2023 11:15:57 +0000 Original-Received: from localhost ([127.0.0.1]:38002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1r6qdg-0000xt-DT for submit@debbugs.gnu.org; Sat, 25 Nov 2023 06:15:56 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:51000 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <me@eshelyaron.com>) id 1r6qdb-0000lI-Lk for 67275@debbugs.gnu.org; Sat, 25 Nov 2023 06:15:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1700910946; bh=zAwIf4kXyIqn09VpgpY+lnDXQWTA9KoK8XUw+DkI0SY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iQh5/y27rgO+/Papz4HKaV7UYbWRhtleIr6QVT5E5vjMmHablxzeifIkpsgqclyw1 +hSJ6KMwbPopOXLe2P/lp3n0rN7RzUHNLKDK0yOwGLkOoEEC+KtBIg4PM87jSwYV7s hUCHw71ofBYEUvLOCFoBVCIvhR+nlyln32D7J3esDKy04ki5R1RuZe/76hqBZd/2Hh eXdjPdBTGqq3eGDn/JwLRQqIwIBQ7E4z4OXS+bCAIo1E1Y5r4FRbDzwaxTnkssbc4F ckEOeyb9xt3HoSqgQPHM/4UkKMfsHt0pFAvP/hgTvbMvFL9o+TCAAgE1G3VYDGgcoO CN52HtP4DLSZA== In-Reply-To: <83r0kecfa6.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Nov 2023 12:12:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs> List-Post: <mailto:bug-gnu-emacs@gnu.org> List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe> Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274956 Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/274956> Eli Zaretskii <eliz@gnu.org> writes: >> From: Eshel Yaron <me@eshelyaron.com> >> Cc: Eli Zaretskii <eliz@gnu.org>, 67275@debbugs.gnu.org >> Date: Mon, 20 Nov 2023 13:26:45 +0100 >> >> Eshel Yaron writes: >> >> > ...Here's the updated patch... >> >> I'm attaching below another patch, which is meant to be applied on top >> of the patch from my previous message. >> >> This patch simplifies Completion Preview mode a bit and, crucially, >> fixes an issue where certain `completion-at-point-functions` >> configurations could prevent `completion-preview-insert` from actually >> inserting the completion suggestion. >> >> I could unify this patch with the previous one and submit them as a >> single patch if that'd be preferable, although in terms of Git history >> it might be nicer to commit them separately IMO. > > Thanks, installed on master. Great, thanks. > Should we now close this bug? Yes, I think so. I have another patch in the works (making Completion Preview mode more convenient for mouse users), but it's probably best to start a separate thread for that. > P.S. Please make a point of mentioning the bug number as part of the > commit log messages, whenever you know the number. (The initial patch > that creates a bug report usually doesn't know the number, but > subsequent submissions do.) Sure, sorry for omitting it here. Eshel