From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.devel Subject: Re: Any objection to adding completing-read-function? Date: Thu, 23 Jun 2011 11:42:04 +0800 Message-ID: References: <21E601B384E14788A5CDF8AD49535D75@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1308800559 14754 80.91.229.12 (23 Jun 2011 03:42:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 23 Jun 2011 03:42:39 +0000 (UTC) Cc: Drew Adams , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 23 05:42:35 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QZaoM-0006Cj-VQ for ged-emacs-devel@m.gmane.org; Thu, 23 Jun 2011 05:42:35 +0200 Original-Received: from localhost ([::1]:48536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZaoM-0000yO-63 for ged-emacs-devel@m.gmane.org; Wed, 22 Jun 2011 23:42:34 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:38774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZao8-0000y8-2J for emacs-devel@gnu.org; Wed, 22 Jun 2011 23:42:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZao7-0002J9-26 for emacs-devel@gnu.org; Wed, 22 Jun 2011 23:42:20 -0400 Original-Received: from mail-iw0-f169.google.com ([209.85.214.169]:42511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZao6-0002J2-VD for emacs-devel@gnu.org; Wed, 22 Jun 2011 23:42:19 -0400 Original-Received: by iwn8 with SMTP id 8so1628178iwn.0 for ; Wed, 22 Jun 2011 20:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=O0bm05nLmA05r2EeCegMv80s+dd/StYEwArZCwQm+iQ=; b=W657pkzUIUGveAj1nALZ+29k96A0tUsC8fzShSibjLAUIS6ckomHTh/K5eZa2qenkq RCnAgrsj4jKKjWfW+6+57S03yjgD5hawgdDzAvpaGSrb4DBqrbBzOurDU0C9Tae+XA9S HFnsFKQxy8ofSLGCsvxrOWi4a96Z2LGevBiMw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=sg8OMZL88R9QQotSayyotsygGp+LkK/V75wFikYkannPiulVwTE2A/NgDeZwPz12wW Qsev3zXyPh2JTQ4TjlnraXjVLWsCeCtpb1CvIwSwkHSnyVG92ixnw1upNeTRyHet/Xtp XEX3jb42TMxIvS4WY99yUavcRyO1Bp8+d54ww= Original-Received: by 10.231.152.130 with SMTP id g2mr294672ibw.65.1308800537776; Wed, 22 Jun 2011 20:42:17 -0700 (PDT) Original-Received: from localhost ([114.247.10.75]) by mx.google.com with ESMTPS id v16sm672538ibe.51.2011.06.22.20.42.11 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Jun 2011 20:42:15 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 22 Jun 2011 17:19:13 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3.50 (Mac OS X 10.6.7) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.214.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:140904 Archived-At: On 2011-06-23 05:19 +0800, Stefan Monnier wrote: > It's an internal hack and should mostly be invisible to the rest of the > Lisp code. It's explained in a comment in minibuf.c (search for > Qlambda). > Passing an initialization-function to read_minibuf (e.g. via the > initial-input arg) would make it possible to get rid of this hack, BTW. Thanks. > BTW, your patch looks OK now, so if your tests indicate that it works > correctly, feel free to install it. Installed so that more people can test it. Leo