From: Leo <sdl.web@gmail.com>
To: "Peter Feigl" <peter.feigl@gmx.at>
Cc: 9453@debbugs.gnu.org
Subject: bug#9453: 23.3; rcirc: INVITE command handled incorrectly
Date: Wed, 07 Sep 2011 10:27:52 +0800 [thread overview]
Message-ID: <m1ipp5ytlj.fsf@gmail.com> (raw)
In-Reply-To: <87pqjd76tx.fsf@nexoid.at> (Peter Feigl's message of "Tue, 06 Sep 2011 22:29:30 +0200")
On 2011-09-07 04:29 +0800, Peter Feigl wrote:
> According to RFC 2812 the INVITE command has two parameters: the user
> and the channel. If I connect to any server via M-x rcirc, join a
> channel and type "/invite user #channel", RCIRC incorrectly
> sends "INVITE :user #channel". It should instead send "INVITE user
> #channel" (note the missing colon). This leads to the server rejecting
> the incorrect invite.
My reading of the code seems to suggest all commands that take more than
one params must be defined by defun-rcirc-command otherwise are
incorrectly handled.
Could you try the following patch (against emacs-23.3)?
Changes in HEAD
lisp/net/rcirc.el | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
Modified lisp/net/rcirc.el
diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index 2baaa951..c0333313 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -2042,6 +2042,16 @@ (defun-rcirc-command join (channel)
(when (not (eq (selected-window) (minibuffer-window)))
(switch-to-buffer buffer))))
+(defun-rcirc-command invite (nick-channel)
+ "Invite NICK to CHANNEL."
+ (interactive (list
+ (concat
+ (completing-read "Invite nick: "
+ (with-rcirc-server-buffer rcirc-nick-table))
+ " "
+ (read-string "Channel: "))))
+ (rcirc-send-string process (concat "INVITE " nick-channel)))
+
;; TODO: /part #channel reason, or consider removing #channel altogether
(defun-rcirc-command part (channel)
"Part CHANNEL."
next prev parent reply other threads:[~2011-09-07 2:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 20:29 bug#9453: 23.3; rcirc: INVITE command handled incorrectly Peter Feigl
2011-09-07 2:27 ` Leo [this message]
2011-09-08 14:17 ` Peter Feigl
2011-09-08 15:30 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ipp5ytlj.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=9453@debbugs.gnu.org \
--cc=peter.feigl@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.