From: "Sébastien Le Callonnec" <sebastien@weblogism.com>
To: 25566@debbugs.gnu.org
Subject: bug#25566: 26.0.50; Crash on C-g with master as of d12e1ddf42
Date: Mon, 30 Jan 2017 16:35:45 +0000 [thread overview]
Message-ID: <m1inowy07y.fsf@weblogism.com> (raw)
In-Reply-To: <87d1f6sx5s.fsf@credativ.de>
I am experiencing the same issue on master on OSX 10.11.6.
A bisect points to this commit:
1392ec7420ee23238a1588b759c631d87a677483 is the first bad commit
commit 1392ec7420ee23238a1588b759c631d87a677483
Author: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed Jan 25 20:27:45 2017 -0800
A quicker check for quit
On some microbenchmarks this lets Emacs run 60% faster on my
platform (AMD Phenom II X4 910e, Fedora 25 x86-64).
* src/atimer.c: Include keyboard.h, for pending_signals.
* src/editfns.c (Fcompare_buffer_substrings):
* src/fns.c (Fnthcdr, Fmemq, Fmemql, Fassq, Frassq, Fplist_put)
(Fnconc, Fplist_member):
Set and clear immediate_quit before and after loop instead of
executing QUIT each time through the loop. This is OK for loops
that affect only locals.
* src/eval.c (process_quit_flag): Now static.
(maybe_quit): New function, containing QUIT’s old body.
* src/fns.c (rarely_quit): New function.
(Fmember, Fassoc, Frassoc, Fdelete, Fnreverse, Freverse)
(Flax_plist_get, Flax_plist_put, internal_equal, Fnconc):
Use it instead of QUIT, for
speed in tight loops that might modify non-locals.
* src/keyboard.h (pending_signals, process_pending_signals):
These belong to keyboard.c, so move them here ...
* src/lisp.h: ... from here.
(QUIT): Redefine in terms of the new maybe_quit function, which
contains this macro’s old definiens. This works well with branch
prediction on processors with return stack buffers, e.g., x86
other than the original Pentium.
:040000 040000 87d5a840fab3795a0ac0ddf3172aa487d2636e7f 3f764784c5b6b1ad19164a3d7997a66542aa7a3e M src
Here is an excerpt of the crash report:
Process: Emacs [23793]
Path: /Applications/Emacs.app/Contents/MacOS/Emacs
Identifier: org.gnu.Emacs
Version: Version 26.0.50 (9.0)
Code Type: X86-64 (Native)
Parent Process: ??? [1]
Responsible: Emacs [23793]
User ID: 502
Date/Time: 2017-01-30 16:27:20.715 +0000
OS Version: Mac OS X 10.11.6 (15G1212)
Crashed Thread: 0 Dispatch queue: com.apple.main-thread
Exception Type: EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Exception Note: EXC_CORPSE_NOTIFY
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libsystem_kernel.dylib 0x00007fff898c68ea __kill + 10
1 org.gnu.Emacs 0x00000001000bac99 terminate_due_to_signal + 153 (emacs.c:398)
2 org.gnu.Emacs 0x00000001000d76f3 emacs_abort + 19
3 org.gnu.Emacs 0x00000001001b3e3a ns_term_shutdown + 122
4 org.gnu.Emacs 0x00000001000bae75 shut_down_emacs + 261 (emacs.c:2094)
5 org.gnu.Emacs 0x00000001000bac66 terminate_due_to_signal + 102 (emacs.c:379)
6 org.gnu.Emacs 0x00000001000d76f3 emacs_abort + 19
7 org.gnu.Emacs 0x000000010013c93f signal_or_quit + 1391 (eval.c:1522)
8 org.gnu.Emacs 0x00000001000c6784 handle_interrupt + 340 (keyboard.c:10459)
9 org.gnu.Emacs 0x00000001000c1a48 gobble_input + 472 (.keyboard.h:472)
10 org.gnu.Emacs 0x00000001000c81b5 unblock_input + 69 (keyboard.c:7143)
11 org.gnu.Emacs 0x00000001001b2c87 ns_select + 903 (nsterm.m:4194)
12 org.gnu.Emacs 0x000000010019f5f8 really_call_select + 88 (thread.c:566)
13 org.gnu.Emacs 0x000000010011d81c flush_stack_call_func + 44 (alloc.c:5110)
14 org.gnu.Emacs 0x000000010019f597 thread_select + 55 (thread.c:590)
15 org.gnu.Emacs 0x00000001001832cd wait_reading_process_output + 4093 (process.c:5367)
16 org.gnu.Emacs 0x0000000100007e25 sit_for + 261 (dispnew.c:5766)
17 org.gnu.Emacs 0x00000001000c3202 read_char + 4802 (keyboard.c:2651)
18 org.gnu.Emacs 0x00000001000bffcb read_key_sequence + 1787 (keyboard.c:9139)
19 org.gnu.Emacs 0x00000001000be76d command_loop_1 + 1229 (keyboard.c:1373)
20 org.gnu.Emacs 0x000000010013c0f7 internal_condition_case + 87 (eval.c:1327)
21 org.gnu.Emacs 0x00000001000cd7a0 command_loop_2 + 48 (keyboard.c:1115)
22 org.gnu.Emacs 0x000000010013b9ae internal_catch + 78 (eval.c:1093)
23 org.gnu.Emacs 0x00000001000bd99e command_loop + 158 (keyboard.c:1095)
24 org.gnu.Emacs 0x00000001000bd8af recursive_edit_1 + 111 (keyboard.c:701)
25 org.gnu.Emacs 0x00000001000bdae3 Frecursive_edit + 227 (keyboard.c:772)
26 org.gnu.Emacs 0x00000001000bc6bd main + 6109 (emacs.c:1688)
27 libdyld.dylib 0x00007fff8ecf85ad start + 1
Thread 1:
0 libsystem_kernel.dylib 0x00007fff898c75e2 __workq_kernreturn + 10
1 libsystem_pthread.dylib 0x00007fff899f0578 _pthread_wqthread + 1283
2 libsystem_pthread.dylib 0x00007fff899ee341 start_wqthread + 13
Thread 2:: Dispatch queue: com.apple.libdispatch-manager
0 libsystem_kernel.dylib 0x00007fff898c7efa kevent_qos + 10
1 libdispatch.dylib 0x00007fff8969f165 _dispatch_mgr_invoke + 216
2 libdispatch.dylib 0x00007fff8969edcd _dispatch_mgr_thread + 52
Thread 3:
0 libsystem_kernel.dylib 0x00007fff898c75e2 __workq_kernreturn + 10
1 libsystem_pthread.dylib 0x00007fff899f0578 _pthread_wqthread + 1283
2 libsystem_pthread.dylib 0x00007fff899ee341 start_wqthread + 13
Thread 4:
0 libsystem_kernel.dylib 0x00007fff898c75e2 __workq_kernreturn + 10
1 libsystem_pthread.dylib 0x00007fff899f0578 _pthread_wqthread + 1283
2 libsystem_pthread.dylib 0x00007fff899ee341 start_wqthread + 13
Thread 5:
0 libsystem_kernel.dylib 0x00007fff898c75e2 __workq_kernreturn + 10
1 libsystem_pthread.dylib 0x00007fff899f0578 _pthread_wqthread + 1283
2 libsystem_pthread.dylib 0x00007fff899ee341 start_wqthread + 13
Thread 6:
0 libsystem_kernel.dylib 0x00007fff898c707a __select + 10
1 org.gnu.Emacs 0x00000001001b550e -[EmacsApp fd_handler:] + 286 (nsterm.m:5486)
2 com.apple.Foundation 0x00007fff868f8e64 __NSThread__start__ + 1351
3 libsystem_pthread.dylib 0x00007fff899f099d _pthread_body + 131
4 libsystem_pthread.dylib 0x00007fff899f091a _pthread_start + 168
5 libsystem_pthread.dylib 0x00007fff899ee351 thread_start + 13
Thread 7:
0 libsystem_kernel.dylib 0x00007fff898c75e2 __workq_kernreturn + 10
1 libsystem_pthread.dylib 0x00007fff899f0578 _pthread_wqthread + 1283
2 libsystem_pthread.dylib 0x00007fff899ee341 start_wqthread + 13
Thread 8:
0 libsystem_kernel.dylib 0x00007fff898c75e2 __workq_kernreturn + 10
1 libsystem_pthread.dylib 0x00007fff899f0578 _pthread_wqthread + 1283
2 libsystem_pthread.dylib 0x00007fff899ee341 start_wqthread + 13
Thread 9:
0 libsystem_kernel.dylib 0x00007fff898c75e2 __workq_kernreturn + 10
1 libsystem_pthread.dylib 0x00007fff899f0578 _pthread_wqthread + 1283
2 libsystem_pthread.dylib 0x00007fff899ee341 start_wqthread + 13
Thread 10:
0 libsystem_kernel.dylib 0x00007fff898c75e2 __workq_kernreturn + 10
1 libsystem_pthread.dylib 0x00007fff899f0578 _pthread_wqthread + 1283
2 libsystem_pthread.dylib 0x00007fff899ee341 start_wqthread + 13
Thread 11:: com.apple.NSEventThread
0 libsystem_kernel.dylib 0x00007fff898c0f72 mach_msg_trap + 10
1 libsystem_kernel.dylib 0x00007fff898c03b3 mach_msg + 55
2 com.apple.CoreFoundation 0x00007fff97843124 __CFRunLoopServiceMachPort + 212
3 com.apple.CoreFoundation 0x00007fff978425ec __CFRunLoopRun + 1356
4 com.apple.CoreFoundation 0x00007fff97841e38 CFRunLoopRunSpecific + 296
5 com.apple.AppKit 0x00007fff8f195d95 _NSEventThread + 149
6 libsystem_pthread.dylib 0x00007fff899f099d _pthread_body + 131
7 libsystem_pthread.dylib 0x00007fff899f091a _pthread_start + 168
8 libsystem_pthread.dylib 0x00007fff899ee351 thread_start + 13
HTH,
Sébastien.
next prev parent reply other threads:[~2017-01-30 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 21:16 bug#25566: 26.0.50; Crash on C-g with master as of d12e1ddf42 Andreas Seltenreich
2017-01-30 16:35 ` Sébastien Le Callonnec [this message]
2017-01-30 17:11 ` Eli Zaretskii
2017-01-30 17:54 ` Sébastien Le Callonnec
2017-01-30 18:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1inowy07y.fsf@weblogism.com \
--to=sebastien@weblogism.com \
--cc=25566@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.