From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Paul W. Rankin" Newsgroups: gmane.emacs.bugs Subject: bug#38757: emacs-27; reliably crashes when wrapping visual lines Date: Fri, 27 Dec 2019 12:27:02 +1000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="67230"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: mu4e 1.2.0; emacs 26.3 To: 38757@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 27 03:28:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ikfMM-000HKD-Mm for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Dec 2019 03:28:15 +0100 Original-Received: from localhost ([::1]:59198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikfML-0007VG-HZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Dec 2019 21:28:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52896) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikfMC-0007Tw-Hv for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2019 21:28:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ikfMA-0000Ru-85 for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2019 21:28:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50400) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ikfMA-0000Ro-4F for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2019 21:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ikfM9-0003NZ-Vb for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2019 21:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Paul W. Rankin" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Dec 2019 02:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38757 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157741364812915 (code B ref -1); Fri, 27 Dec 2019 02:28:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Dec 2019 02:27:28 +0000 Original-Received: from localhost ([127.0.0.1]:56373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikfLW-0003M2-7e for submit@debbugs.gnu.org; Thu, 26 Dec 2019 21:27:27 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:55327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikfLV-0003Lv-3m for submit@debbugs.gnu.org; Thu, 26 Dec 2019 21:27:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52688) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikfLS-0007SV-Es for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2019 21:27:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ikfLP-00006w-UX for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2019 21:27:18 -0500 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:56817) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ikfLP-00006Y-BC for bug-gnu-emacs@gnu.org; Thu, 26 Dec 2019 21:27:15 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 12C47717 for ; Thu, 26 Dec 2019 21:27:13 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 26 Dec 2019 21:27:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paulwrankin.com; h=from:to:subject:date:message-id:mime-version:content-type; s= fm1; bh=W/NVMbMHzT6yKdW8P5SHWHzeZ+LYlAdzyHMUUH9ZoJQ=; b=b1KfaepZ UPzoWbQ1p5fiV/5Lj0uYL9e/TDKMk4Q3liztsvfQNaOOKp6mBxth3seZIlu8RG2d oSUfeWvEKmS7pla09dfQAkfw0R7RYlTHD7AvzFVQd6MIN91nqa60y+pC7PvVf6LY gTEr6qgm0Vz9AOduLkgO9VD1B3hS9Cnq0j8/lIYO9Se+jhTnbAX90QkZREzASZL5 qo+eiuHQ/RWvakEXrlQ69zcghq+uU+3mGWYDkh0iVaYge7zQICgbeFUHgxpVxcsW ++JVLrz2ygwx03b5A4YPINn6AigvRSNFFF9i04wfvddO9pJ4bWxHihC+uocJpoem oE4IfojHUdLjjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=W/NVMbMHzT6yKdW8P5SHWHzeZ+LYl AdzyHMUUH9ZoJQ=; b=M3brT7OjVAgqxHbGigL0XY3haJI40yNT4JAF/AUkZ6TiS 0qzJ1K9uYNx58P0akZcbq2IMtj6XTVPpxKm7sYYt+vsCWtYKsenQsvdNp7pZ4869 whbYzZ9ms9yQgr7ai7Hx7JSDigpb8GlKWe1vm6xLbvgvCjySen5g89On9bCvzzsb whPQ4HUI9IGz3EpXLuQfp9mm6/9VHFL0JY2RxmmXa5tt53lYVSUU2rmnPOjPAfmc OpF/mBhBrpfSAcInjdQVauOKI/HoE5HOomVaL1ZrGGiI/i9MMdv5ooJFTk0el6kO TPmSuc1dciMRI9u102fiYDrmOUdQrFLSjjd+P2zVw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddvjedggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpegfhffvufffkfggtgesthdtredttd ertdenucfhrhhomhepfdfrrghulhcuhgdrucftrghnkhhinhdfuceohhgvlhhlohesphgr uhhlfihrrghnkhhinhdrtghomheqnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpmh gvlhhprgdrohhrghdpsggrtghksghlrgiivggsvddrtghomhdpghhnuhdrohhrghdpghht hhhusgdrtghomhenucfkphepuddvtddrvddvrdefkedrfeeknecurfgrrhgrmhepmhgrih hlfhhrohhmpehhvghllhhosehprghulhifrhgrnhhkihhnrdgtohhmnecuvehluhhsthgv rhfuihiivgeptd X-ME-Proxy: Original-Received: from localhost (unknown [120.22.38.38]) by mail.messagingengine.com (Postfix) with ESMTPA id 013183060783 for ; Thu, 26 Dec 2019 21:27:09 -0500 (EST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173794 Archived-At: Emacs 27 when run in console mode (i.e. without NS/X window system) will reliably crash completely when running stable code for minor mode olivetti (included below in full for convenience). This code has been stable since 24.5, and so represents a regression in 27.0, I suspect in the display code. The crash occurs when minor mode is enabled in a buffer with text lines long enough to wrap visually, or enabled in empty buffer within which enough text is then entered to wrap lines visually. I am happy to test fixes applied to the emacs-27 branch. Steps to reproduce: 1. checkout emacs-27 branch and build 2. emacs -nw -Q 3. load-library olivetti (included in full below) 4. olivetti-mode [in buffer with wrapped lines] Expected results: Lines wrap as normal without crash. Stable code for minor mode functions as normal. Actual results: Emacs crashes to console without warning or error message. ;;; olivetti.el --- Minor mode for a nice writing environment -*- lexical-binding: t; -*- ;; Copyright (c) 2014-2019 Free Software Foundation, Inc. ;; Copyright (c) 2019 Paul W. Rankin ;; Author: Paul W. Rankin ;; Keywords: wp, text ;; Version: 1.8.1 ;; Package-Requires: ((emacs "24.5")) ;; URL: https://gthub.com/rnkn/olivetti ;; This file is not part of GNU Emacs. ;; This program is free software; you can redistribute it and/or modify ;; it under the terms of the GNU General Public License as published by ;; the Free Software Foundation, either version 3 of the License, or ;; (at your option) any later version. ;; This program is distributed in the hope that it will be useful, ;; but WITHOUT ANY WARRANTY; without even the implied warranty of ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the ;; GNU General Public License for more details. ;; You should have received a copy of the GNU General Public License ;; along with this program. If not, see . ;;; Commentary: ;; # Olivetti # ;; A simple Emacs minor mode for a nice writing environment. ;; Screenshot: https://f002.backblazeb2.com/file/pwr-share/olivetti.png ;; ## Features ## ;; - Set a desired text body width to automatically resize window margins to ;; keep the text comfortably in the middle of the window. ;; - Text body width can be the number of characters (an integer) or a fraction ;; of the window width (a float between 0.0 and 1.0). ;; - Interactively change body width with: ;; olivetti-shrink C-c { { { ... ;; olivetti-expand C-c } } } ... ;; olivetti-set-width C-c \ ;; - If olivetti-body-width is an integer, the text body width will scale with ;; use of text-scale-mode, whereas if a fraction (float) then the text body ;; width will remain at that fraction. ;; - Optionally remember the state of visual-line-mode on entry and recall its ;; state on exit. ;; Olivetti keeps everything it does buffer-local, so you can write prose in one ;; buffer and code in another, side-by-side in the same frame. For those looking ;; for a hardcore distraction-free writing mode with a much larger scope, I ;; recommend writeroom-mode: https://github.com/joostkremers/writeroom-mode. ;; ## Requirements ## ;; - Emacs 24.5 ;; ## Installation ## ;; The latest stable release of Olivetti is available via [MELPA-stable] ;; and can be installed with: ;; M-x package-install RET olivetti RET ;; Alternately, download the [latest release], move this file into your ;; load-path and add to your .emacs/init.el file: ;; (require 'olivetti) ;; If you prefer the latest but perhaps unstable version, install via ;; [MELPA], or clone the repository into your load-path and require as ;; above: ;; git clone https://github.com/rnkn/olivetti.git ;; [melpa]: https://melpa.org/#/olivetti "MELPA" ;; [melpa-stable]: https://stable.melpa.org/#/olivetti "MELPA-stable" ;; [latest release]: https://github.com/rnkn/olivetti/releases/latest "Olivetti latest release" ;; ## Contributing ## ;; Please report bugs and request features at: ;; https://github.com/rnkn/olivetti/issues ;; ## Hints ## ;; To always use a different width for a specific file, set a File ;; Variable: ;; M-x add-file-local-variable RET olivetti-body-width RET 66 RET ;; See (info "(emacs) File Variables") ;;; Code: (defgroup olivetti () "Minor mode for a nice writing environment" :prefix "olivetti-" :group 'text) ;;; Variables (defvar-local olivetti--visual-line-mode nil "Non-nil if `visual-line-mode' is active when `olivetti-mode' is turned on.") ;;; Options (defcustom olivetti-body-width 70 "Text body width to which to adjust relative margin width. If an integer, set text body width to that integer in columns; if a floating point between 0.0 and 1.0, set text body width to that fraction of the total window width. An integer is best if you want text body width to remain constant, while a floating point is best if you want text body width to change with window width. The floating point can anything between 0.0 and 1.0 (exclusive), but it's better to use a value between about 0.33 and 0.9 for best effect. This option does not affect file contents." :type '(choice (integer 70) (float 0.5)) :safe 'numberp) (make-variable-buffer-local 'olivetti-body-width) (defcustom olivetti-minimum-body-width 40 "Minimum width in columns that text body width may be set." :type 'integer :safe 'integerp) (defcustom olivetti-lighter " Olv" "Mode-line indicator for `olivetti-mode'." :type '(choice (const :tag "No lighter" "") string) :safe 'stringp) (defcustom olivetti-recall-visual-line-mode-entry-state t "Recall the state of `visual-line-mode' upon exiting. When non-nil, if `visual-line-mode' is inactive upon activating `olivetti-mode', then `visual-line-mode' will be deactivated upon exiting. The reverse is not true." :type 'boolean :safe 'booleanp) ;;; Set Environment (defun olivetti-set-all-margins () "Balance window margins in all windows displaying current buffer. Cycle through all windows in all frames displaying the current buffer, and call `olivetti-set-margins'." (dolist (window (get-buffer-window-list nil nil t)) (olivetti-set-margins window))) (defun olivetti-set-margins (&optional frame-or-window) "Balance window margins displaying current buffer. If FRAME-OR-WINDOW is a frame, cycle through windows displaying current buffer in that frame, otherwise only work on the selected window. First find the `olivetti-safe-width' to which to set `olivetti-body-width', then find the appropriate margin size relative to each window. Finally set the window margins, taking care that the maximum size is 0." (if (framep frame-or-window) (dolist (window (get-buffer-window-list nil nil frame-or-window)) (olivetti-set-margins window)) ;; FRAME-OR-WINDOW passed below *must* be a window (olivetti-reset-window frame-or-window) (let ((width (olivetti-safe-width olivetti-body-width frame-or-window)) (frame (window-frame frame-or-window)) (window-width (window-total-width frame-or-window)) (fringes (window-fringes frame-or-window)) left-fringe right-fringe margin-total left-margin right-margin) (cond ((integerp width) (setq width (olivetti-scale-width width))) ((floatp width) (setq width (* window-width width)))) (setq left-fringe (/ (car fringes) (float (frame-char-width frame))) right-fringe (/ (cadr fringes) (float (frame-char-width frame)))) (setq margin-total (max (/ (- window-width width) 2) 0) left-margin (max (round (- margin-total left-fringe)) 0) right-margin (max (round (- margin-total right-fringe)) 0)) (set-window-parameter frame-or-window 'split-window 'olivetti-split-window) (set-window-margins frame-or-window left-margin right-margin)))) (defun olivetti-reset-all-windows () "Remove Olivetti's parameters and margins from all windows. Cycle through all windows displaying current buffer and call `olivetti-reset-window'." (dolist (window (get-buffer-window-list nil nil t)) (olivetti-reset-window window))) (defun olivetti-reset-window (window) "Remove Olivetti's parameters and margins from WINDOW." (when (eq (window-parameter window 'split-window) 'olivetti-split-window) (set-window-parameter window 'split-window nil)) (set-window-margins window nil)) (defun olivetti-split-window (&optional window size side pixelwise) "Call `split-window' after resetting WINDOW. Pass SIZE, SIDE and PIXELWISE unchanged." (olivetti-reset-window window) (split-window window size side pixelwise)) (defun olivetti-split-window-sensibly (&optional window) "Like `olivetti-split-window' but call `split-window-sensibly'. Pass WINDOW unchanged." (olivetti-reset-window window) (split-window-sensibly window)) ;;; Calculate Width (defun olivetti-scale-width (n) "Scale N in accordance with the face height. For compatibility with `text-scale-mode', if `face-remapping-alist' includes a :height property on the default face, scale N by that factor if it is a fraction, by (height/100) if it is an integer, and otherwise scale by 1." (let ((height (plist-get (cadr (assq 'default face-remapping-alist)) :height))) (cond ((integerp height) (* n (/ height 100.0))) ((floatp height) (* n height)) (t n)))) (defun olivetti-safe-width (width window) "Parse WIDTH to a safe value for `olivetti-body-width' for WINDOW. May return a float with many digits of precision." (let ((window-width (window-total-width window)) (fringes (window-fringes window)) (min-width (+ olivetti-minimum-body-width (% olivetti-minimum-body-width 2)))) (setq window-width (- window-width (/ (* (max (car fringes) (cadr fringes)) 2) (float (frame-char-width (window-frame window)))) (% window-width 2))) (cond ((integerp width) (max min-width (min width (floor window-width)))) ((floatp width) (max (/ min-width window-width) (min width 1.0))) ((user-error "`olivetti-body-width' must be an integer or a float") ;; FIXME: This code is unreachable since we signal an error before ;; getting here!? (eval (car (get 'olivetti-body-width 'standard-value)) t))))) ;;; Width Interaction (defun olivetti-set-width (n) "Set text body width to N with relative margins. N may be an integer specifying columns or a float specifying a fraction of the window width." (interactive (list (or current-prefix-arg (read-number "Set text body width (integer or float): " olivetti-body-width)))) (setq olivetti-body-width n) (olivetti-set-all-margins) (message "Text body width set to %s" olivetti-body-width)) (defun olivetti-expand (&optional arg) "Incrementally increase the value of `olivetti-body-width'. If prefixed with ARG, incrementally decrease." (interactive "P") (let* ((p (if arg -1 1)) (n (cond ((integerp olivetti-body-width) (+ olivetti-body-width (* 2 p))) ((floatp olivetti-body-width) (+ olivetti-body-width (* 0.01 p)))))) (setq olivetti-body-width (olivetti-safe-width n (selected-window)))) (olivetti-set-all-margins) (message "Text body width set to %s" olivetti-body-width) (set-transient-map (let ((map (make-sparse-keymap))) (define-key map "}" #'olivetti-expand) (define-key map "{" #'olivetti-shrink) map))) (defun olivetti-shrink (&optional arg) "Incrementally decrease the value of `olivetti-body-width'. If prefixed with ARG, incrementally increase." (interactive "P") (let ((p (unless arg t))) (olivetti-expand p))) ;;; Mode Definition (defvar olivetti-mode-map (let ((map (make-sparse-keymap))) (define-key map (kbd "C-c }") #'olivetti-expand) (define-key map (kbd "C-c {") #'olivetti-shrink) (define-key map (kbd "C-c \\") #'olivetti-set-width) map) "Mode map for `olivetti-mode'.") (define-obsolete-function-alias 'turn-on-olivetti-mode #'olivetti-mode "1.7.0") ;;;###autoload (define-minor-mode olivetti-mode "Olivetti provides a nice writing environment. Window margins are set to relative widths to accomodate a text body width set with `olivetti-body-width'." :init-value nil :lighter olivetti-lighter (if olivetti-mode (progn (cond ((<= emacs-major-version 24) (add-hook 'window-configuration-change-hook #'olivetti-set-all-margins t t)) ((<= emacs-major-version 26) (add-hook 'window-configuration-change-hook #'olivetti-set-all-margins t t) (add-hook 'window-size-change-functions #'olivetti-set-margins t t)) ((<= 27 emacs-major-version) (add-hook 'window-size-change-functions #'olivetti-set-margins t t))) (add-hook 'change-major-mode-hook #'olivetti-reset-all-windows nil t) (setq-local split-window-preferred-function #'olivetti-split-window-sensibly) (setq olivetti--visual-line-mode visual-line-mode) (unless olivetti--visual-line-mode (visual-line-mode 1)) (olivetti-set-all-margins)) (remove-hook 'window-configuration-change-hook #'olivetti-set-all-margins t) (remove-hook 'window-size-change-functions #'olivetti-set-margins t) (olivetti-reset-all-windows) (when (and olivetti-recall-visual-line-mode-entry-state (not olivetti--visual-line-mode)) (visual-line-mode 0)) (kill-local-variable 'split-window-preferred-function) (kill-local-variable 'olivetti--visual-line-mode))) (provide 'olivetti) ;;; olivetti.el ends here