From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43559: 28.0.50; [PATCH] Add csharp support to cc-mode Date: Wed, 21 Jul 2021 15:18:02 +0200 Message-ID: References: <3a5043ee-ae0e-426f-b74d-fbba25ea4b21@email.android.com> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29372"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Mackenzie , Lars Ingebrigtsen , jostein@kjonigsen.net, 43559@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 21 15:19:54 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6C8f-0007OA-Nf for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 15:19:53 +0200 Original-Received: from localhost ([::1]:45080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6C8e-0002wl-Nm for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 09:19:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6C7q-0002jN-Qa for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 09:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6C7q-0000ks-I3 for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 09:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6C7q-0000HC-6p for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 09:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jul 2021 13:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43559 X-GNU-PR-Package: emacs Original-Received: via spool by 43559-submit@debbugs.gnu.org id=B43559.16268734891002 (code B ref 43559); Wed, 21 Jul 2021 13:19:02 +0000 Original-Received: (at 43559) by debbugs.gnu.org; 21 Jul 2021 13:18:09 +0000 Original-Received: from localhost ([127.0.0.1]:36494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6C6z-0000G6-Gj for submit@debbugs.gnu.org; Wed, 21 Jul 2021 09:18:09 -0400 Original-Received: from out0.migadu.com ([94.23.1.103]:31802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6C6v-0000Fp-F8 for 43559@debbugs.gnu.org; Wed, 21 Jul 2021 09:18:08 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1626873484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wZt74hJkQSSqffFxyTzTEAO+8gSC3O75kshCdqFctP4=; b=OqtFXvK/jpT9XVuW1ugeEHqN8Sx1wNRzWgYuqeOEAbaH3YomnF4iqeb1YMQA8O4xGYcwFf M0MbE7tZDLNXpma0oyxJ7wlSTeNzJQx9CSPto3htmdx9v+gzDbUnyJcNR8U7CGkH6mDPXQ s/UqqJbY+N0KUp1HlpkhzfHEJ47tkY/IP/eCFbs3BB7oKEB1ch3LV5YPw+YL3NtCvezAW9 mvIsI5HuhAZrsk1GYpRVjPwwAP5/C8are+/SmXcXeLfymdTSFOU1hCDnFJULpB+8QUQKj4 YUuhpf3ESnyihvtbej9zKP50i7TsIBdAluklWYLDSvwnFMHPQhk0nLd3IZt5Sg== In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210436 Archived-At: Stefan Monnier writes: >> > Great! Including it in GNU ELPA would be cool. Stefan? > > Fine by me. > Cool! >> There are some performance issues that are being addressed by Alan >> with regards to multiline strings. > > That should have no bearing on inclusion into GNU ELPA. No, I assume it should be even easier to change csharp-mode when those fixes arrive. > >> The paperwork should be very easy, as I _think_ the only people with >> commits that needs paperwork is Jostein and me. > > Can you double check? > I'm not completely sure how I'd double check that for there to be no issues at all legally. When I did the rewrite I did it without looking at the already existing code, since I wanted the option to include it in emacs at some point. If you look at https://github.com/emacs-csharp/csharp-mode/blame/master/csharp-mode.el you'll find that most commits are from me, except the header comments, which I took from the existing code. Most of the other commits that are referenced in that blame is either whitespace that didn't change when the new version was merged as well as some one line bug patches that came after the new version arrived. I assume they are ok to add to elpa, given their size? Other commits are ci related and an indentation fix. How do I verify this? Theo