From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.devel Subject: Re: Strange test in xdisp.c Date: Mon, 15 Nov 2004 23:50:07 -0500 Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1100580643 20613 80.91.229.6 (16 Nov 2004 04:50:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 16 Nov 2004 04:50:43 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 16 05:50:37 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CTvIa-0000ek-00 for ; Tue, 16 Nov 2004 05:50:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CTvRK-00058z-Aj for ged-emacs-devel@m.gmane.org; Mon, 15 Nov 2004 23:59:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CTvRD-00058k-RJ for emacs-devel@gnu.org; Mon, 15 Nov 2004 23:59:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CTvRD-00058Y-F9 for emacs-devel@gnu.org; Mon, 15 Nov 2004 23:59:31 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CTvRD-00058V-Cs for emacs-devel@gnu.org; Mon, 15 Nov 2004 23:59:31 -0500 Original-Received: from [206.47.199.166] (helo=simmts8-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CTvI7-0000v6-PB for emacs-devel@gnu.org; Mon, 15 Nov 2004 23:50:08 -0500 Original-Received: from empanada.home ([70.48.82.50]) by simmts8-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20041116045007.EVJH1623.simmts8-srv.bellnexxia.net@empanada.home>; Mon, 15 Nov 2004 23:50:07 -0500 Original-Received: by empanada.home (Postfix, from userid 502) id B762C36E22B; Mon, 15 Nov 2004 23:50:08 -0500 (EST) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "Tue, 16 Nov 2004 01:05:07 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (darwin) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29905 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29905 > XFASTINT and a test for <= 0 seems a bit odd to me. > /* If bottom moved off end of frame, change mode line percentage. */ > if (XFASTINT (w->window_end_pos) <= 0 > && Z != IT_CHARPOS (it)) > w-> update_mode_line = Qt; Hmm... indeed odd. I'd guess that the "== 0" part of "<= 0" is the one used and the "< 0" part is basically never activated. I'd hope that if window_end_pos had ever been something else than an integer, ENABLE_CHECKING would have cought it (I always run with it). Stefan