From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el Date: Thu, 02 Sep 2021 20:46:12 +0200 Message-ID: Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27878"; mail-complaints-to="usenet@ciao.gmane.io" To: 50345@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 02 20:47:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLrk2-0006sl-BF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 20:47:15 +0200 Original-Received: from localhost ([::1]:56292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLrk0-0006CR-Gv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 14:47:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLrjq-0006B1-4j for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLrjp-0007NK-Sb for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLrjp-0002Od-QF for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Sep 2021 18:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16306083899169 (code B ref -1); Thu, 02 Sep 2021 18:47:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Sep 2021 18:46:29 +0000 Original-Received: from localhost ([127.0.0.1]:42050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLrjI-0002Np-TH for submit@debbugs.gnu.org; Thu, 02 Sep 2021 14:46:29 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:59414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLrjH-0002Ng-6c for submit@debbugs.gnu.org; Thu, 02 Sep 2021 14:46:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLrjG-0005yt-4V for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:46:26 -0400 Original-Received: from out1.migadu.com ([2001:41d0:2:863f::]:10812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLrjA-0006gQ-0G for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:46:25 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1630608374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=MCWaruJGD6Ydx0EPC3PhNerVzlp6NoyfsD3/U1rkkIk=; b=MQ7dw+3CGN8KVRynNsYux45viJJ/TdtEI6sfNpaOVm1hOLZhuKolJg4+iuQNcIhe5+1MwY bbbqTz0PinZlNUg0XQ7ZjBFhciVWEYS+Wh4wK8KkthawJDv+fJpGvKFKxFnS+55gY8XjiK qjX5R0mBcPi1Bs8huiIe4EpqYiwqqLKxYppq7nvWn4WUpg19ro0hfKKSlMM/PogJW1Or+U XWgeyDjRQoNrxfQGc9YObcHruRS8BJfItFhl0P9KVXRgBk1G+IFW3yaDp8sFHss5tZMETf 0Ja7ypnUhYgwSHR9wic3ssCEIWYVm8dITlZ2eGOgEKncLD0IJwd1kdYwjJtG+g== X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: theo@thornhill.no Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=theo@thornhill.no; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213301 Archived-At: --=-=-= Content-Type: text/plain Hello! In $DAYJOB, right now we are working on a larger redesign of our customer facing web app. As such I'm knee deep in css these days. I've noticed there are some holes in the completion keywords, and I'd like to start addressing those. Hence the first, simple starting-point patch. Before I continue adding patches, I'd like some pointers as to how I should structure them. For example - lots of keywords are now shared between grid and flex. An example is `align-content', which is now under a section devoted to flex. However, there are some newer, grid-related completion keywords that are not in this section, nor anywhere else. See line 306 in css-mode.el. I guess the solution here is to add `start' and `end' there, but I want to check first. Should I add several, smaller patches, or one big correction of most of the things I see at the moment? Best, Theodor Thornhill --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-selection-to-css-pseudo-element-ids.patch >From b0a4ec120d3371982878e523f33c34bed59c1371 Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Thu, 2 Sep 2021 20:27:19 +0200 Subject: [PATCH] Add selection to css-pseudo-element-ids * lisp/textmodes/css-mode.el (css-pseudo-element-ids): Add selection as an element id --- lisp/textmodes/css-mode.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 61a2f6b3bc..3bcd9c9766 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -57,7 +57,7 @@ "Identifiers for pseudo-classes.") (defconst css-pseudo-element-ids - '("after" "before" "first-letter" "first-line") + '("after" "before" "first-letter" "first-line" "selection") "Identifiers for pseudo-elements.") (defconst css-at-ids -- 2.30.1 (Apple Git-130) --=-=-=--