From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59662: 29.0.50; [PATCH] Add treesit--indent-defun Date: Fri, 02 Dec 2022 22:09:55 +0100 Message-ID: References: <5B538888-E454-4F75-B3B8-AB20E10B3E89@gmail.com> <83o7sniokt.fsf@gnu.org> <56840149-5EB9-4C22-841F-45F410BFC885@thornhill.no> <83edtjimyo.fsf@gnu.org> <875yet975l.fsf@thornhill.no> <87y1rp7dw2.fsf@thornhill.no> Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26071"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) Cc: 59662@debbugs.gnu.org, casouri@gmail.com, eliz@gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 22:11:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1DJY-0006cT-Sl for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 22:11:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1DJL-0005Wy-2m; Fri, 02 Dec 2022 16:11:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1DJI-0005TH-Cn for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 16:11:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1DJG-0008R2-HS for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 16:11:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1DJG-0001Mn-2m for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 16:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 21:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59662 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: "Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors" , 59662@debbugs.gnu.org, casouri@gmail.com, Eli Zaretskii Original-Received: via spool by submit@debbugs.gnu.org id=B.16700154095216 (code B ref -1); Fri, 02 Dec 2022 21:11:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Dec 2022 21:10:09 +0000 Original-Received: from localhost ([127.0.0.1]:48888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1DIO-0001M3-PP for submit@debbugs.gnu.org; Fri, 02 Dec 2022 16:10:09 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:50648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1DIM-0001Ls-Bm for submit@debbugs.gnu.org; Fri, 02 Dec 2022 16:10:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1DIM-00052J-4C for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 16:10:06 -0500 Original-Received: from sonic309-25.consmr.mail.ir2.yahoo.com ([77.238.179.83]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1DIJ-00089S-Vr for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 16:10:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1670015399; bh=DJglOBtneC8JBhV0a9lwof2RAnc8oeQAYmONvvRh6po=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=lZfK5ITWIapj9B8v0qZDmJ97eRxsKjDRLmOzdP4NZFXjEVOH3Qb8dAE73Am3sircx4tQ2IFdvuJMbzjRa6jZqxcLCPKTzjoDPF/twpFDkrQN+tFx45YjQX09L9u/tv6+/kIrv36oTUUFjLOqXhtboTelCQlA82aAd/Af1TNGZxgkIFEUeqsj8r+mudrL3KMPz7qUeL5/jUwkH+Kf6RLUUIJKKkQ3XyD2mOKK+IA41AC+sutm8MLxXTF4UVhyR8WeM3AhL5tv7wOHGawZ2sgMW8y1JsS3WQ4efwL2TOZX0/kqmNpkg1gmqG9MCFLgrs9MayDXYMfyJnvSfBDsFtoDNA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670015399; bh=kkFFcyka8OQhN5shUkg/QjF+7MT7VmnnEEfWl9FjEu1=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Jkp4t6ksE42QDd/s/kQkq87Gy6xNsjiVjif8q4H0wu3ikENIdWrBd/XMVKwLyoctybDhZJ3eOg1nLbKMb+r21F+yc+zqIGcJV1rgY9DpVOVbqniEEDHt9vnr7ORcNFXc3ZK1pLf0wVsU5T80/+W09LNar9jsuFQD2og1YyU2ayF2FWe+va3F0GrH4Qv6JXxpiro9Rl/SPVe1CxfiG43ti169yeD29jcLh2I01e185277vsLyFAppxsB0+kDFEqhNd/jVh+RbtJINCp4ef3mpN0LUXdCT0j9AT5/V9RSRMMr6HD5CFKEFqZyExAYD6eUag5zYe8Ry9hxKMftyq6Llpw== X-YMail-OSG: AYsug0wVM1lO8DPRs2APaiMH.E79zw2wNPyaNb1qtP0Qvzc..cC9anVgjqFy9m5 1iLDouKrKKp4dmbOOsIUHO5hog3wpT27vV6zl5yCYQq238CdFdRmyRFYS7LoORSfkue3yDgzTafu YS5Uh3gc7sGZnSog57MIUNff6.c8tMYdK6nN_nODvIy6jJnF27P8ONazQqFA0hCBKElxwRt2Xphy lecCL1gNVk8Muq.AQWVUiD7921_Icm_iNkjzQuASscIQkW.Mqq2Xhoj6chsWx4zmxyhve3OBm6L9 YZTvEAhZXAqnjzhqzjF0Ok9x4nVyEYRHvXfXZcjKzd2HRTTMh_PRONlgNmCMrAXuZ8N3A2gxg5Kv Rsj3UGQrqiQhl4Kp4bORc.I_Br9Q3G4pUPbghKqhAfNqBdUzF0pd8wSuIxBQ0M2YIvc6Pwt4Z6BO NuAfQcwr3SkMf0puyWkUgYyk.Jyyo27peV7TiWBVN.ZxwnvEEoU8BzrhHvhkzONEwphTtwjuJkAo Myf94jIN5219P7pJY5o6_LBWuWmpl0RBa36WB8m6kBaA4zMgPXnpdiD5oVdKplNOO3MeBD3.XCma ZTbqy25w4WCGNy6OPei9T1COzYAlbzCj2q9fJw4rd8.nAAHYVgtYAL86j17R9J241lDoMcjDGpfG WvD33DnBcOpxUFNKbq7qCbZSu4mxfy4.dLCGWLiyAGYzK0H36UPs9DxF5Lbxe6WjXm60obpIdJLw AKvajetef1uEppWUoiL27CqTMzWy7vuO0c_qiS3rngnuX37y7TtrkTA2Xn7oPfQwSM1GJN.pztqE V_7n1m9OMKw9Ky2hdgiPDUkORgn5PDEox9gBmxPtsy X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ir2.yahoo.com with HTTP; Fri, 2 Dec 2022 21:09:59 +0000 Original-Received: by hermes--production-ir2-5795fc58c8-hsgkz (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e09e85b4492bae80807ffe45c45e28e6; Fri, 02 Dec 2022 21:09:57 +0000 (UTC) In-Reply-To: <87y1rp7dw2.fsf@thornhill.no> (Theodor Thornhill's message of "Fri, 02 Dec 2022 21:24:13 +0100") X-Mailer: WebService/1.1.20926 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=77.238.179.83; envelope-from=mardani29@yahoo.es; helo=sonic309-25.consmr.mail.ir2.yahoo.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249786 Archived-At: Theodor Thornhill writes: > Right - thanks. However, this makes me wonder - should we really be > setting mark here? I see that c-indent-defun does not, and it feels > weird that indenting adds to the mark ring. What do you think? My > first patch used > > (indent-region > (treesit-node-start node) > (treesit-node-end node)) > > Which behaves similarly to c-indent-defun. > > See attached patch. I don't have a strong opinion, but if we can indent without setting the mark, I think it'd be a cleaner command. Specially if c-indent-defun doesn't set the mark either.