From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.devel Subject: Re: Can we not introduce frivolous indentation change to define-minor-mode? Date: Wed, 06 Jan 2016 19:50:33 +0800 Message-ID: References: <83d1tg57p6.fsf@gnu.org> <87fuybqdby.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1452081071 27514 80.91.229.3 (6 Jan 2016 11:51:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jan 2016 11:51:11 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 06 12:51:03 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aGmcI-0005s0-BQ for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2016 12:51:02 +0100 Original-Received: from localhost ([::1]:53810 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGmcH-00041l-LP for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2016 06:51:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGmc5-00041c-AW for emacs-devel@gnu.org; Wed, 06 Jan 2016 06:50:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGmc2-0005Td-2d for emacs-devel@gnu.org; Wed, 06 Jan 2016 06:50:49 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:40466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGmc1-0005TV-Se for emacs-devel@gnu.org; Wed, 06 Jan 2016 06:50:46 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aGmbx-0005cj-Kc for emacs-devel@gnu.org; Wed, 06 Jan 2016 12:50:42 +0100 Original-Received: from 221.222.155.102 ([221.222.155.102]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 06 Jan 2016 12:50:41 +0100 Original-Received: from sdl.web by 221.222.155.102 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 06 Jan 2016 12:50:41 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 221.222.155.102 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (OS X 10.11.2) Cancel-Lock: sha1:dNP0rlZmGUwB+CbDn/ghDKX4KwE= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197694 Archived-At: Hi Oleh, On 2016-01-06 10:14 +0100, Oleh Krehel wrote: > I added an (indent 1) statement around a year ago. The reason is that it > didn't have one before, and that (indent 1) is obviously the correct > indentation level. > > Every `define-minor-mode' statement in the core (and org-mode, and most > of ELPA) already obeys the (intent 1) convention. It seems that you were > defining minor modes in your config (and ELPA) with nil instead of the > docstring. I suggest to either add a docstring or put a newline after > the minor mode name. > > Oleh The doc-string generated by define-minor-mode is fine in many cases so `nil' is legitimate. Secondly those forms already indent correctly without introducing (indent 1). What (indent 1) does is penalise people like me whose years-old code now indents differently. If there are no good reasons I'd like to revert the change to keep the behaviour consistent with previous emacsen. WDYT? Leo