From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change. Date: Sun, 28 Feb 2016 01:23:55 +0800 Message-ID: References: <20160227055054.15422.83807@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456593882 8809 80.91.229.3 (27 Feb 2016 17:24:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Feb 2016 17:24:42 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 27 18:24:33 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aZibU-0005x6-V6 for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2016 18:24:29 +0100 Original-Received: from localhost ([::1]:55635 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZibU-0006jY-9l for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2016 12:24:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZibG-0006jT-UL for emacs-devel@gnu.org; Sat, 27 Feb 2016 12:24:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZibD-0000Hn-NU for emacs-devel@gnu.org; Sat, 27 Feb 2016 12:24:14 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:50491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZibD-0000Hh-Hy for emacs-devel@gnu.org; Sat, 27 Feb 2016 12:24:11 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aZib9-0005nO-Ca for emacs-devel@gnu.org; Sat, 27 Feb 2016 18:24:09 +0100 Original-Received: from 221.222.147.227 ([221.222.147.227]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 27 Feb 2016 18:24:07 +0100 Original-Received: from sdl.web by 221.222.147.227 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 27 Feb 2016 18:24:07 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 18 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 221.222.147.227 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (OS X 10.11.3) Cancel-Lock: sha1:78WXBFYrCVkS8XmUiUZGMJ0QoTQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200719 Archived-At: On 2016-02-27 10:02 -0500, Kaushal Modi wrote: > FWIW I actually liked the indent change that was put in the first place. If > you look at the explanation in that commit, it makes sense why that indent > change was done. Sorry I can't check the explanation now since I lost connection to my server which hosts the emacs repo. Could you post the explanation? > I did not understand why it was reverted in this recent commit. > > Kaushal Could you show me a code example that has bad indentation that (indent 3) fixes? Adding (indent 3) gives bad indentation to some previously well-indented code. The previous indentation setting seems more flexible. Leo