From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#24585: 25.1; avoid hack in ggtags.el to run compilation-auto-jump timer Date: Sat, 08 Oct 2016 01:07:30 +0800 Message-ID: References: <83twcrks7q.fsf@gnu.org> <83int5jpde.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1475862172 1699 195.159.176.226 (7 Oct 2016 17:42:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 7 Oct 2016 17:42:52 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (macOS 10.12) Cc: 24585@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 07 19:42:49 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsZAR-0007hl-7r for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Oct 2016 19:42:43 +0200 Original-Received: from localhost ([::1]:37559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsZAP-0007z5-Ll for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Oct 2016 13:42:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsYcv-0003iE-AL for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2016 13:08:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsYcr-0007aG-Vj for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2016 13:08:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsYcr-0007aB-Rv for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2016 13:08:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bsYcr-0001pL-LL for bug-gnu-emacs@gnu.org; Fri, 07 Oct 2016 13:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Oct 2016 17:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24585 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24585-submit@debbugs.gnu.org id=B24585.14758600636997 (code B ref 24585); Fri, 07 Oct 2016 17:08:01 +0000 Original-Received: (at 24585) by debbugs.gnu.org; 7 Oct 2016 17:07:43 +0000 Original-Received: from localhost ([127.0.0.1]:48023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsYcZ-0001om-9b for submit@debbugs.gnu.org; Fri, 07 Oct 2016 13:07:43 -0400 Original-Received: from mail-pf0-f181.google.com ([209.85.192.181]:36349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsYcX-0001oa-FK for 24585@debbugs.gnu.org; Fri, 07 Oct 2016 13:07:41 -0400 Original-Received: by mail-pf0-f181.google.com with SMTP id i85so26086999pfa.3 for <24585@debbugs.gnu.org>; Fri, 07 Oct 2016 10:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version; bh=sDE+rJHYE1tIqvMB7pW3J3y7euiSRVMxUL7rFB3UByo=; b=X75L8Dh6f0n54SUtpLYqKqNCHmt15smT5GABjxdfIOOA68bGuOA0cZNPf7OGpdmloK fIy65k9KfZJyTicbFba5R3CSbDt0H0z/hI/6AzJBW6IM6q//B2DY2HurjaitHhPkwlcN Y3XiHWBi8da5xS2R2iJlMqNk2reiv6FNuccjDblQPpwOUfE1SUvcZUrO7MIgiEhBN5ie WbhugfvvzlJD+fSB3tvZsXsgD8p2Vft6j5mwR86QrkbChAadIfHlxJPZxpEWVyHKaFFy +pN4n5KMunx4fSjR06L8tOFUVsdmKlR8lVkFseDbG12fwsZe39+0+MRkIIGtBjvKkEl5 ZxLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:face:date :in-reply-to:message-id:user-agent:mime-version; bh=sDE+rJHYE1tIqvMB7pW3J3y7euiSRVMxUL7rFB3UByo=; b=KDubL4YNNGRPPnag475TLWBwyzWqlMJxDts9hwqp3ZYKu6/dH01ehkwGUe6buMqFGs xFk3N5tHCPwY4HAFxgYLfR7UasjTqty/3TWKZT7nqIaOya+rU40JSy0/zFsvf9n8+e/j k5nx4tOrpgSROIRtmwoBvyGj838Z9p3w1F7Y1B8f/oYX28OB2If4m4ZL62YzYhQDBPUp PgZJhAH8KqUMSkkEv8saAX5n2poqT7DdQUIAl1oyg+Hg814lx7vRJNx+tQfDg1Sur4+H 0iAqaU5Hs97YA3u0muTweHWGMGLqErIs5xYkqCPk8OuVh5ZYKkilVa+oDPhO8huABiCP XCzw== X-Gm-Message-State: AA6/9RmTgxzWz1IDJ72htlZlS6XMVKGSBlSETQbrqgo0GdbN9p7AQsUWvKg/bRKeqpwUsQ== X-Received: by 10.98.94.5 with SMTP id s5mr37667631pfb.126.1475860055852; Fri, 07 Oct 2016 10:07:35 -0700 (PDT) Original-Received: from zeuss-MacBook-Pro.local ([139.59.241.182]) by smtp.gmail.com with ESMTPSA id sv8sm17991151pab.18.2016.10.07.10.07.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Oct 2016 10:07:34 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Fri, 07 Oct 2016 08:46:10 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124166 Archived-At: On 2016-10-07 08:46 -0400, Stefan Monnier wrote: > Not sure what you mean by "fired", but in any case, no: font-lock is not > used for that (tho it has been used at some point before > compilation-auto-jump was introduced, IIRC). Instead, it's done via > syntax-propertize (which can be triggered in all kinds of ways, > including font-lock). This (defun compilation-mode-font-lock-keywords () "Return expressions to highlight in Compilation mode." (append '((compilation--ensure-parse)) compilation-mode-font-lock-keywords)) and the only place in compile.el that mentions syntax-propertize is in a comment. > How 'bout something like the following: > > - Add a new var compilation-pending-auto-jump set buffer-locally to > non-nil when compilation-error-properties calls run-with-timer. > - in compilation-auto-jump, check this var before doing anything and set > it back to nil. > - in ggtags, call compilation-auto-jump to make sure this timer is run > before yours. I think the issue is compilation-error-properties can happen after compilation-finish-functions. And calling compilation--ensure-parse in ggtags-global-handle-exit doesn't seem to help. Leo