From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64266: [PATCH] ; * lisp/progmodes/project.el (project-current): Doc fix. Date: Sat, 24 Jun 2023 17:35:12 +0300 Message-ID: Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39971"; mail-complaints-to="usenet@ciao.gmane.io" To: 64266@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 24 16:36:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qD4NE-000AAt-Iu for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Jun 2023 16:36:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qD4Mu-0007OV-Bk; Sat, 24 Jun 2023 10:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD4Ms-0007OC-Bc for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 10:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qD4Ms-0002Y4-3h for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 10:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qD4Mr-0004OO-TL for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 10:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jun 2023 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64266 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.168761734116849 (code B ref -1); Sat, 24 Jun 2023 14:36:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Jun 2023 14:35:41 +0000 Original-Received: from localhost ([127.0.0.1]:41218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD4MW-0004Nh-HZ for submit@debbugs.gnu.org; Sat, 24 Jun 2023 10:35:40 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:40700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD4MU-0004NZ-Nf for submit@debbugs.gnu.org; Sat, 24 Jun 2023 10:35:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD4MU-0007Ha-7R for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 10:35:38 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD4MS-0002Tv-L7 for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 10:35:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1687617335; bh=t8D/bpbs0duWJzngkEFU5d6ERY4pydHSTJlQsrsFaPU=; h=From:To:Subject:Date:From; b=jrrP9ETGcmygxfKXEZH7NM4AD4cWBDNHDzLiplgOWp+rZKjAuSfxY/QrzWU4wg2Ou xEaT+5J+jtpvS5zAn3yiJDv8aZKpjzTrMtSTGaCBt95jz/N2hlrM1Q57kYDsmdFQHw dY3vf8iyPVxx/PGGizukEnb1PedUyO6K7so0K1n2SectfkXQA8KTjTYEukM8swy53C cGq8PIpM1K8+2drVwmhb6ojqxX9yjuiUMWbfh4kMitqLsRIhOnWLsinzMWDEYgvYvu J1UDzVSaI4WGojg46qqjgxW3Jv2BDiY5cvlzS5CyAD9S9Q41zn5MIkJyCBfMeVOU2N OqeHL1DTz2tMg== Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263993 Archived-At: --=-=-= Content-Type: text/plain Tags: patch Hi, Since commit 9efa6d2cf28f4e21f23bb0dbfedc59a4286dab12, the function `project-current` uses the function specified by `project-prompter` rather than calling `project-prompt-project-dir` directly. As a result, it can prompt for a project by its name rather than by its root directory (depending on the value of `project-prompter`), but the doc string of `project-current` says that it "asks the user for a directory" without mentioning `project-prompter`. This patch clarifies that `project-current` uses `project-prompter` for prompting. In GNU Emacs 30.0.50 (build 18, x86_64-apple-darwin22.5.0, NS appkit-2299.60 Version 13.4 (Build 22F66)) of 2023-06-24 built on Dazzs-MBP Repository revision: 77c2f05d773271cb59ebfd994b06a4075cacbfa8 Repository branch: master Windowing system distributor 'Apple', version 10.3.2299 System Description: macOS 13.4 Configured using: 'configure 'CFLAGS=-g0 -O3' --with-native-compilation --with-json --with-imagemagick --with-tree-sitter --enable-link-time-optimization' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-progmodes-project.el-project-current-Doc-fix.patch >From 8dbf48e71fd68b10478a70ec8453e5e0c61e176d Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sat, 24 Jun 2023 17:16:19 +0300 Subject: [PATCH] ; * lisp/progmodes/project.el (project-current): Doc fix. Avoid saying that 'project-current' asks specifically for a directory, as it can also ask for a project's directory by other identifiers, such as the project's name, when 'project-prompter' is set to a different value than the default 'project-prompt-project-dir'. --- lisp/progmodes/project.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 56c524bcab5..5e8628bbd0e 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -219,9 +219,9 @@ project-current When no project is found in that directory, the result depends on the value of MAYBE-PROMPT: if it is nil or omitted, return nil, -else ask the user for a directory in which to look for the -project, and if no project is found there, return a \"transient\" -project instance. +else call the function specified by `project-prompter' to prompt +the user for a project's directory, and if no project is found +there, return a \"transient\" project instance. The \"transient\" project instance is a special kind of value which denotes a project rooted in that directory and includes all -- 2.41.0 --=-=-=--