From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 67180@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#67180: 30.0.50; 'pp-to-string' emits extra newline
Date: Wed, 15 Nov 2023 14:10:39 +0100 [thread overview]
Message-ID: <m1fs17go1c.fsf@sp-byods-145-109-9-233.wireless.uva.nl> (raw)
In-Reply-To: <jwvjzqjnq1n.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 15 Nov 2023 07:52:50 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> On Emacs 29 and earlier, with `-Q`, we have:
>>>
>>> (pp-to-string "foo")
>>> => "\"foo\""
>>>
>>> On master with `-Q`, we get an extra newline at the end of the string:
>>>
>>> (pp-to-string "foo")
>>> => "\"foo\"
>>> "
>
> Is that a problem?
FWIW, I think that this change is for the better, but it is
incompatible, and sadly it broke `agda2-mode`. (In some sense this
probably Agda's "fault", because I don't really understand why they're
using `pp-to-string` the way they do.) My suggestion was simply to
explicitly mention this new behavior in NEWS or some such.
> I also see that the old `pp-to-string` added that same extra newline for
> slightly more complex input:
>
> ELISP> (pp-to-string '("foo"))
> "(\"foo\")
> "
> ELISP>
>
>> Stefan, is this due to your changes in pp?
>
> Yes.
>
>
> Stefan
next prev parent reply other threads:[~2023-11-15 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 20:12 bug#67180: 30.0.50; 'pp-to-string' emits extra newline Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-14 20:37 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-15 12:01 ` Eli Zaretskii
2023-11-15 12:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-15 13:10 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-11-16 14:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 15:34 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 16:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1fs17go1c.fsf@sp-byods-145-109-9-233.wireless.uva.nl \
--to=bug-gnu-emacs@gnu.org \
--cc=67180@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=me@eshelyaron.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.